Hadoop Common
  1. Hadoop Common
  2. HADOOP-6885

Fix java doc warnings in Groups and RefreshUserMappingsProtocol

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are a couple java docs warnings in Groups and RefreshUserMappingsProtocol.

      1. hadoop-6885-2.patch
        2 kB
        Eli Collins
      2. hadoop-6885-1.patch
        1 kB
        Eli Collins

        Activity

        Hide
        Eli Collins added a comment -

        Patch attached.

        Show
        Eli Collins added a comment - Patch attached.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12450658/hadoop-6885-1.patch
        against trunk revision 979919.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450658/hadoop-6885-1.patch against trunk revision 979919. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/644/console This message is automatically generated.
        Hide
        Jakob Homan added a comment -

        Eli-
        Funny, I don't get these as warnings when I run ant javadoc. I do however, get:

          [javadoc] /Users/jhoman/work/git/hadoop-common/src/java/org/apache/hadoop/ipc/Client.java:945: warning - Tag @link: 
        can't find call(Writable, InetSocketAddress, Class, UserGroupInformation) in org.apache.hadoop.ipc.Client
          [javadoc] /Users/jhoman/work/git/hadoop-common/src/java/org/apache/hadoop/ipc/Client.java:958: warning - Tag @link: 
        can't find call(Writable, InetSocketAddress, Class, UserGroupInformation) in org.apache.hadoop.ipc.Client
        

        Could you update the patch to fix these warnings as well and I'll +1?

        Show
        Jakob Homan added a comment - Eli- Funny, I don't get these as warnings when I run ant javadoc . I do however, get: [javadoc] /Users/jhoman/work/git/hadoop-common/src/java/org/apache/hadoop/ipc/Client.java:945: warning - Tag @link: can't find call(Writable, InetSocketAddress, Class, UserGroupInformation) in org.apache.hadoop.ipc.Client [javadoc] /Users/jhoman/work/git/hadoop-common/src/java/org/apache/hadoop/ipc/Client.java:958: warning - Tag @link: can't find call(Writable, InetSocketAddress, Class, UserGroupInformation) in org.apache.hadoop.ipc.Client Could you update the patch to fix these warnings as well and I'll +1?
        Hide
        Jakob Homan added a comment -

        Canceling patch post-review.

        Show
        Jakob Homan added a comment - Canceling patch post-review.
        Hide
        Eli Collins added a comment -

        Updated the patch to fix the IPC javadoc warnings. The earlier warnings are seen when using javadoc-dev. Both targets build cleanly on trunk with this patch. Thanks Jakob.

        Show
        Eli Collins added a comment - Updated the patch to fix the IPC javadoc warnings. The earlier warnings are seen when using javadoc-dev. Both targets build cleanly on trunk with this patch. Thanks Jakob.
        Hide
        Jakob Homan added a comment -

        +1. Verified javadoc is fixed. Hudson is completely AWOL and this is a minor documentation patch, so I've committed it. Resolving as fixed. Thanks, Eli.

        Show
        Jakob Homan added a comment - +1. Verified javadoc is fixed. Hudson is completely AWOL and this is a minor documentation patch, so I've committed it. Resolving as fixed. Thanks, Eli.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #360 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/360/)
        HADOOP-6885. Fix java doc warnings in Groups and RefreshUserMappingsProtocol. Contributed by Eli Collins.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #360 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/360/ ) HADOOP-6885 . Fix java doc warnings in Groups and RefreshUserMappingsProtocol. Contributed by Eli Collins.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #428 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/428/)
        HADOOP-6885. Fix java doc warnings in Groups and RefreshUserMappingsProtocol. Contributed by Eli Collins.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #428 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/428/ ) HADOOP-6885 . Fix java doc warnings in Groups and RefreshUserMappingsProtocol. Contributed by Eli Collins.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development