Hadoop Common
  1. Hadoop Common
  2. HADOOP-6836

[Herriot]: Generic method for adding/modifying the attributes for new configuration.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      herriot

      Description

      HADOP-6772 deals with
      Common utilities for system tests.
      1. A method for restarting the daemon with new configuration.
      c throws Exception;

      2. A method for restarting the daemon with default configuration.
      public void restart() throws Exception;

      3. A method for waiting until daemon is stop.
      public void waitForClusterToStop() throws Exception;

      In this some variables are made of String, instead of Long. Those needs ot be changed too. So, can this method
      "public static void restartClusterWithNewConfig(Hashtable<String,Long> props, String confFile) throws Exception;"
      be generalized to accepts string too. All otehr methods should work as usual.

      1. HADOOP-6836.patch
        1 kB
        Vinay Kumar Thota
      2. 6836-ydist-security.patch
        1 kB
        Vinay Kumar Thota

        Issue Links

          Activity

          Hide
          Vinay Kumar Thota added a comment -

          Patch for yahoo distribution security branch.

          Show
          Vinay Kumar Thota added a comment - Patch for yahoo distribution security branch.
          Hide
          Vinay Kumar Thota added a comment -

          Patches for both trunk and yahoo dist security branch.

          Show
          Vinay Kumar Thota added a comment - Patches for both trunk and yahoo dist security branch.
          Hide
          Iyappan Srinivasan added a comment -

          +1 for the patch

          Show
          Iyappan Srinivasan added a comment - +1 for the patch
          Hide
          Konstantin Boudnik added a comment -

          Patch looks good. +1
          Please do the usual patch verification through Hudson (submit the patch) to make sure all is cool.

          Show
          Konstantin Boudnik added a comment - Patch looks good. +1 Please do the usual patch verification through Hudson (submit the patch) to make sure all is cool.
          Hide
          Vinay Kumar Thota added a comment -

          Cos, patch is working fine and I don't see any issues.Please commit into trunk.

          Show
          Vinay Kumar Thota added a comment - Cos, patch is working fine and I don't see any issues.Please commit into trunk.
          Hide
          Konstantin Boudnik added a comment -

          Vinay, usual verification means running a patch through test-patch process. One can do it by clicking on 'Submit patch' link in a JIRA.

          Show
          Konstantin Boudnik added a comment - Vinay, usual verification means running a patch through test-patch process. One can do it by clicking on 'Submit patch' link in a JIRA.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448033/HADOOP-6836.patch
          against trunk revision 962998.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448033/HADOOP-6836.patch against trunk revision 962998. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/608/console This message is automatically generated.
          Hide
          Vinay Kumar Thota added a comment -

          I can see there are 6 javadoc warnings and all of them are related to warning: sun.security.krb5.Config.So, I don't think the patch could raise the number of java doc warning considering the scope of the patch.

          Show
          Vinay Kumar Thota added a comment - I can see there are 6 javadoc warnings and all of them are related to warning: sun.security.krb5.Config.So, I don't think the patch could raise the number of java doc warning considering the scope of the patch.
          Hide
          Konstantin Boudnik added a comment -

          +1 patch looks good. The warnings are apparently unrelated. Will commit it shortly.

          Show
          Konstantin Boudnik added a comment - +1 patch looks good. The warnings are apparently unrelated. Will commit it shortly.
          Hide
          Konstantin Boudnik added a comment -

          I have committed this. Thanks Vinay.

          Show
          Konstantin Boudnik added a comment - I have committed this. Thanks Vinay.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #325 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/325/)
          HADOOP-6836. [Herriot]: Generic method for adding/modifying the attributes for new configuration. Contributed by Vinay Thota.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #325 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/325/ ) HADOOP-6836 . [Herriot] : Generic method for adding/modifying the attributes for new configuration. Contributed by Vinay Thota.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #393 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/393/)
          HADOOP-6836. [Herriot]: Generic method for adding/modifying the attributes for new configuration. Contributed by Vinay Thota.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #393 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/393/ ) HADOOP-6836 . [Herriot] : Generic method for adding/modifying the attributes for new configuration. Contributed by Vinay Thota.

            People

            • Assignee:
              Vinay Kumar Thota
              Reporter:
              Iyappan Srinivasan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development