Hadoop Common
  1. Hadoop Common
  2. HADOOP-6819

[Herriot] Shell command for getting the new exceptions in the logs returning exitcode 1 after executing successfully.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      herriot

      Description

      I have found an corner case issue while executing the shell command for getting the new exceptions in the logs. The problem could see whenever the log files are empty and trying to get the new exceptions count, it returns the output is 0 ,however it returns the exitcode is 1 instead of 0. grep -vc in the command is not giving the expected exitcode because its not handling the multiple in options.

      1. HADOOP-6819.patch
        0.7 kB
        Vinay Kumar Thota
      2. 6819-ydist-security.patch
        0.7 kB
        Vinay Kumar Thota

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #392 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/392/)
          HADOOP-6819. [Herriot] Shell command for getting the new exceptions in
          the logs returning exitcode 1 after executing successfully. Contributed
          by Vinay Thota.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #392 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/392/ ) HADOOP-6819 . [Herriot] Shell command for getting the new exceptions in the logs returning exitcode 1 after executing successfully. Contributed by Vinay Thota.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #324 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/324/)
          HADOOP-6819. [Herriot] Shell command for getting the new exceptions in
          the logs returning exitcode 1 after executing successfully. Contributed
          by Vinay Thota.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #324 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/324/ ) HADOOP-6819 . [Herriot] Shell command for getting the new exceptions in the logs returning exitcode 1 after executing successfully. Contributed by Vinay Thota.
          Hide
          Konstantin Boudnik added a comment -

          I have committed this to trunk and 0.21 branch. Thanks Vinay!

          Show
          Konstantin Boudnik added a comment - I have committed this to trunk and 0.21 branch. Thanks Vinay!
          Hide
          Vinay Kumar Thota added a comment -

          Cos, It was there in patch available state quite a long time.Please commit it.

          Show
          Vinay Kumar Thota added a comment - Cos, It was there in patch available state quite a long time.Please commit it.
          Hide
          Konstantin Boudnik added a comment -

          As far as I can see all javadoc warnings are related to warning: sun.security.krb5.* and there are 6 of them. So, I don't think the patch in question could raise the number of javadoc warning considering the scope of the patch.

          Show
          Konstantin Boudnik added a comment - As far as I can see all javadoc warnings are related to warning: sun.security.krb5.* and there are 6 of them. So, I don't think the patch in question could raise the number of javadoc warning considering the scope of the patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12446839/HADOOP-6819.patch
          against trunk revision 953863.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446839/HADOOP-6819.patch against trunk revision 953863. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/581/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          +1 patch looks good.
          Submitting to verify the trunk version of it.

          Show
          Konstantin Boudnik added a comment - +1 patch looks good. Submitting to verify the trunk version of it.
          Hide
          Vinay Kumar Thota added a comment -

          Patch for trunk.

          Show
          Vinay Kumar Thota added a comment - Patch for trunk.
          Hide
          Vinay Kumar Thota added a comment -

          Patch for yahoo security dist branch.

          Show
          Vinay Kumar Thota added a comment - Patch for yahoo security dist branch.

            People

            • Assignee:
              Vinay Kumar Thota
              Reporter:
              Vinay Kumar Thota
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development