Hadoop Common
  1. Hadoop Common
  2. HADOOP-6813

Add a new newInstance method in FileSystem that takes a "user" as argument

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      I've just committed this to 0.21.

      Description

      In order to implement HDFS-1000 for trunk, I need to have a newInstance API in FileSystem that takes a "user" as an argument.

      1. h-6813.patch
        3 kB
        Devaraj Das

        Issue Links

          Activity

          Hide
          Devaraj Das added a comment -

          Straightforward patch.

          Show
          Devaraj Das added a comment - Straightforward patch.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12446533/h-6813.patch
          against trunk revision 952454.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446533/h-6813.patch against trunk revision 952454. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/571/console This message is automatically generated.
          Hide
          Boris Shkolnik added a comment -

          +1
          committed to trunk. Thanks Devaraj.

          Show
          Boris Shkolnik added a comment - +1 committed to trunk. Thanks Devaraj.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/285/)
          HADOOP-6813. Add a new newInstance method in FileSystem that takes a user as argument

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/285/ ) HADOOP-6813 . Add a new newInstance method in FileSystem that takes a user as argument
          Hide
          Chris Douglas added a comment -

          This issue went from created to committed in less than an hour. Changes to the FileSystem API should require more notice and explanation than was provided in this JIRA, though this looks like a reasonable convenience method to me.

          Show
          Chris Douglas added a comment - This issue went from created to committed in less than an hour. Changes to the FileSystem API should require more notice and explanation than was provided in this JIRA, though this looks like a reasonable convenience method to me.
          Hide
          Devaraj Das added a comment -

          This issue went from created to committed in less than an hour. Changes to the FileSystem API should require more notice and explanation than was provided in this JIRA, though this looks like a reasonable convenience method to me.

          Hmm.. makes sense to wait longer for such changes. The main reason for having this API is to take care of libhdfs. There is an API in libhdfs that tries to connect on behalf of users. In order to support that API, I added the method in FileSystem. The other option would be to create an UGI object and pass it to newInstance but that would complicate things a bit (to do with creating UGI objects in C code, etc.).

          Show
          Devaraj Das added a comment - This issue went from created to committed in less than an hour. Changes to the FileSystem API should require more notice and explanation than was provided in this JIRA, though this looks like a reasonable convenience method to me. Hmm.. makes sense to wait longer for such changes. The main reason for having this API is to take care of libhdfs. There is an API in libhdfs that tries to connect on behalf of users. In order to support that API, I added the method in FileSystem. The other option would be to create an UGI object and pass it to newInstance but that would complicate things a bit (to do with creating UGI objects in C code, etc.).
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #360 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/360/)
          HADOOP-6813. Add a new newInstance method in FileSystem that takes a user as argument

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #360 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/360/ ) HADOOP-6813 . Add a new newInstance method in FileSystem that takes a user as argument
          Hide
          Eli Collins added a comment -

          Flagging for Tom to commit to 21.

          Show
          Eli Collins added a comment - Flagging for Tom to commit to 21.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #297 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/297/)
          Move entries for HADOOP-6769 and HADOOP-6813 to 0.21 section of CHANGES.txt

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #297 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/297/ ) Move entries for HADOOP-6769 and HADOOP-6813 to 0.21 section of CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #364 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/364/)
          Move entries for HADOOP-6769 and HADOOP-6813 to 0.21 section of CHANGES.txt

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #364 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/364/ ) Move entries for HADOOP-6769 and HADOOP-6813 to 0.21 section of CHANGES.txt

            People

            • Assignee:
              Devaraj Das
              Reporter:
              Devaraj Das
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development