Hadoop Common
  1. Hadoop Common
  2. HADOOP-6802

Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 2.0.2-alpha
    • Component/s: conf, fs
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In CommonConfigurationKeys.java:

      public static final String FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir";

      The variable FS_CLIENT_BUFFER_DIR_KEY and string "fs.client.buffer.dir" are not used anywhere (Checked Hadoop Common, Hdfs and Mapred projects), it seems they should be removed.

      1. HADOOP-6802.txt
        5 kB
        Sho Shimauchi
      2. HADOOP-6802.txt
        5 kB
        Sho Shimauchi

        Activity

        Erik Steffl created issue -
        Nigel Daley made changes -
        Field Original Value New Value
        Fix Version/s 0.22.0 [ 12314296 ]
        Sho Shimauchi made changes -
        Labels newbie
        Sho Shimauchi made changes -
        Assignee Sho Shimauchi [ sho.shimauchi ]
        Hide
        Sho Shimauchi added a comment -

        attached a patch

        Show
        Sho Shimauchi added a comment - attached a patch
        Sho Shimauchi made changes -
        Attachment HADOOP-6802.txt [ 12510567 ]
        Harsh J made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.24.0, 0.23.1 [ 12317652, 12318884 ]
        Arun C Murthy made changes -
        Target Version/s 0.23.1, 0.24.0 [ 12318884, 12317652 ] 0.23.2 [ 12319855 ]
        Sho Shimauchi made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Sho Shimauchi added a comment -

        attached again

        Show
        Sho Shimauchi added a comment - attached again
        Sho Shimauchi made changes -
        Attachment HADOOP-6802.txt [ 12516021 ]
        Sho Shimauchi made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sho Shimauchi made changes -
        Affects Version/s 0.23.0 [ 12315569 ]
        Affects Version/s 0.22.0 [ 12314296 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516021/HADOOP-6802.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.fs.viewfs.TestViewFsTrash

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/765//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/765//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516021/HADOOP-6802.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/765//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/765//console This message is automatically generated.
        Hide
        Sho Shimauchi added a comment -

        This test failure is caused by another ticket HADOOP-8110.

        Show
        Sho Shimauchi added a comment - This test failure is caused by another ticket HADOOP-8110 .
        Robert Joseph Evans made changes -
        Target Version/s 0.23.2 [ 12319855 ] 2.0.0, 3.0.0 [ 12320352, 12320357 ]
        Hide
        Harsh J added a comment -

        +1, committing this shortly. Patch still applies well.

        Show
        Harsh J added a comment - +1, committing this shortly. Patch still applies well.
        Harsh J made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Component/s conf [ 12310711 ]
        Component/s fs [ 12310689 ]
        Hide
        Harsh J added a comment -

        Committed to branch-2 and trunk. Thank you for your continuing contributions, Sho!

        Show
        Harsh J added a comment - Committed to branch-2 and trunk. Thank you for your continuing contributions, Sho!
        Harsh J made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 2.0.0-alpha, 3.0.0 [ 12320352, 12320357 ]
        Fix Version/s 2.0.1-alpha [ 12321441 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2484 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2484/)
        HADOOP-6802. Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2484 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2484/ ) HADOOP-6802 . Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2416 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2416/)
        HADOOP-6802. Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2416 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2416/ ) HADOOP-6802 . Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1093/)
        HADOOP-6802. Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784)

        Result = FAILURE
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1093 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1093/ ) HADOOP-6802 . Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/)
        HADOOP-6802. Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784)

        Result = SUCCESS
        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1127 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/ ) HADOOP-6802 . Remove FS_CLIENT_BUFFER_DIR_KEY = "fs.client.buffer.dir" from CommonConfigurationKeys.java (not used, deprecated). Contributed by Sho Shimauchi. (harsh) (Revision 1355784) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1355784 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322473 ]
        Fix Version/s 2.1.0-alpha [ 12321441 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Sho Shimauchi
            Reporter:
            Erik Steffl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development