Hadoop Common
  1. Hadoop Common
  2. HADOOP-6790

Instrumented (Herriot) build uses too wide mask to include aspect files.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      herriot

      Description

      AspectJ compiler needs to use narrower mask to look for sources and aspect files.
      Otherwise, injectfaults might fail if called after inject-system-faults.
      This is very minor issue and won't appear until we'll be having actually FI tests in the Common.

      1. HADOOP-6790.patch
        1.0 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          Fix for the problem.

          Show
          Konstantin Boudnik added a comment - Fix for the problem.
          Hide
          Konstantin Boudnik added a comment -

          to verify.

          Show
          Konstantin Boudnik added a comment - to verify.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445592/HADOOP-6790.patch
          against trunk revision 948573.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445592/HADOOP-6790.patch against trunk revision 948573. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/70/console This message is automatically generated.
          Hide
          Sharad Agarwal added a comment -

          Patch looks fine.

          Show
          Sharad Agarwal added a comment - Patch looks fine.
          Hide
          Sharad Agarwal added a comment -

          Rerunning hudson.

          Show
          Sharad Agarwal added a comment - Rerunning hudson.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12445592/HADOOP-6790.patch
          against trunk revision 965725.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445592/HADOOP-6790.patch against trunk revision 965725. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/626/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Same old deprecation warnings from security stuff: unrelated. I am going to commit this.

          Show
          Konstantin Boudnik added a comment - Same old deprecation warnings from security stuff: unrelated. I am going to commit this.
          Hide
          Konstantin Boudnik added a comment -

          I have committed this.

          Show
          Konstantin Boudnik added a comment - I have committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #333 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/333/)
          HADOOP-6790. Instrumented (Herriot) build uses too wide mask to include aspect files. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #333 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/333/ ) HADOOP-6790 . Instrumented (Herriot) build uses too wide mask to include aspect files. Contributed by Konstantin Boudnik.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #400 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/400/)
          HADOOP-6790. Instrumented (Herriot) build uses too wide mask to include aspect files. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #400 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/400/ ) HADOOP-6790 . Instrumented (Herriot) build uses too wide mask to include aspect files. Contributed by Konstantin Boudnik.

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development