Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-6758

MapFile.fix does not allow index interval definition

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1, 0.20.2
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When using the static methond MapFile.fix() there is no way to override the default IndexInterval that is 128.

      The IndexInterval should be taken from the configuration that is passed to the method.

      int indexInterval = 128; 
      indexInterval = conf.getInt(INDEX_INTERVAL, indexInterval); 
      
      
      1. HADOOP-6758.patch
        0.6 kB
        Gianmarco De Francisci Morales
      2. HADOOP-6758.patch
        0.6 kB
        Gianmarco De Francisci Morales
      3. HADOOP-6758.patch
        0.6 kB
        Gianmarco De Francisci Morales

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12444062/HADOOP-6758.patch
          against trunk revision 941662.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/513/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444062/HADOOP-6758.patch against trunk revision 941662. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/513/console This message is automatically generated.
          Hide
          azaroth Gianmarco De Francisci Morales added a comment -

          Made a mistake generating the patch.

          No unit test included because it is just a configuration option.

          Show
          azaroth Gianmarco De Francisci Morales added a comment - Made a mistake generating the patch. No unit test included because it is just a configuration option.
          Hide
          azaroth Gianmarco De Francisci Morales added a comment -

          Sorry to ask, but how do I try to resubmit my patch?

          Show
          azaroth Gianmarco De Francisci Morales added a comment - Sorry to ask, but how do I try to resubmit my patch?
          Hide
          azaroth Gianmarco De Francisci Morales added a comment -

          Resubmitting patch

          Show
          azaroth Gianmarco De Francisci Morales added a comment - Resubmitting patch
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12444067/HADOOP-6758.patch
          against trunk revision 995285.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system tests framework. The patch passed system tests framework compile.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444067/HADOOP-6758.patch against trunk revision 995285. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system tests framework. The patch passed system tests framework compile. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/678/console This message is automatically generated.
          Hide
          azaroth Gianmarco De Francisci Morales added a comment -

          Patch is ready for review

          Show
          azaroth Gianmarco De Francisci Morales added a comment - Patch is ready for review
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12444067/HADOOP-6758.patch
          against trunk revision 1031422.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/36//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/36//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/36//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444067/HADOOP-6758.patch against trunk revision 1031422. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/36//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/36//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/36//console This message is automatically generated.
          Hide
          azaroth Gianmarco De Francisci Morales added a comment -

          There are no tests included because it is just a configuration option.
          Patch is ready for review.

          Show
          azaroth Gianmarco De Francisci Morales added a comment - There are no tests included because it is just a configuration option. Patch is ready for review.
          Hide
          tomwhite Tom White added a comment -

          I've just committed this. Thanks Gianmarco!

          (In the version I committed I inlined the assignment and referenced Writer.INDEX_INTERVAL rather than the string constant.)

          Show
          tomwhite Tom White added a comment - I've just committed this. Thanks Gianmarco! (In the version I committed I inlined the assignment and referenced Writer.INDEX_INTERVAL rather than the string constant.)
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #416 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/416/)
          HADOOP-6758. MapFile.fix does not allow index interval definition. Contributed by Gianmarco De Francisci Morales.

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #416 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/416/ ) HADOOP-6758 . MapFile.fix does not allow index interval definition. Contributed by Gianmarco De Francisci Morales.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk #504 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/504/)
          HADOOP-6758. MapFile.fix does not allow index interval definition. Contributed by Gianmarco De Francisci Morales.

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #504 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/504/ ) HADOOP-6758 . MapFile.fix does not allow index interval definition. Contributed by Gianmarco De Francisci Morales.

            People

            • Assignee:
              azaroth Gianmarco De Francisci Morales
              Reporter:
              azaroth Gianmarco De Francisci Morales
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development