Details
Description
Looking in hadoop-daemon.sh we see the start command redirects logs to the log file by creating a new file. It does not append to the log.
nohup nice -n $HADOOP_NICENESS "$HADOOP_HOME"/bin/hadoop --config $HADOOP_CONF_DIR $command "$@" > "$log" 2>&1 < /dev/null &
I believe output should be appended to the log file so logrotate copytruncate works. Currently a large log file cannot be truncated without restarting the running service, which causes issues in production environments.
The improved line would be exactly the same, except use >> to open the log file in append mode.
nohup nice -n $HADOOP_NICENESS "$HADOOP_HOME"/bin/hadoop --config $HADOOP_CONF_DIR $command "$@" >> "$log" 2>&1 < /dev/null &
Attachments
Attachments
Issue Links
- is duplicated by
-
HADOOP-9902 Shell script rewrite
- Resolved