Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-6724

IPC doesn't properly handle IOEs thrown by socket factory

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.3, 0.21.0, 0.22.0
    • Fix Version/s: 0.20.3, 0.21.0, 0.22.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If the socket factory throws an IOE inside setupIOStreams, then handleConnectionFailure will be called with socket still null, and thus generate an NPE on socket.close(). This ends up orphaning clients, etc.

      1. hadoop-6724.txt
        2 kB
        Todd Lipcon
      2. hadoop-6724-20-1.patch
        2 kB
        Eli Collins

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12442801/hadoop-6724.txt
        against trunk revision 937881.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442801/hadoop-6724.txt against trunk revision 937881. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/479/console This message is automatically generated.
        Hide
        tomwhite Tom White added a comment -

        +1 (Nice Mockito test.)

        Show
        tomwhite Tom White added a comment - +1 (Nice Mockito test.)
        Hide
        tomwhite Tom White added a comment -

        I've just committed this. Thanks Todd!

        Show
        tomwhite Tom White added a comment - I've just committed this. Thanks Todd!
        Hide
        eli Eli Collins added a comment -

        Patch for 20 attached.

        Show
        eli Eli Collins added a comment - Patch for 20 attached.
        Hide
        tlipcon Todd Lipcon added a comment -

        Think we should commit this to branch-20 as well. It's pretty nasty and a simple fix.

        Show
        tlipcon Todd Lipcon added a comment - Think we should commit this to branch-20 as well. It's pretty nasty and a simple fix.
        Hide
        eli Eli Collins added a comment -

        I ran test-patch and committed this to branch 20.

        Show
        eli Eli Collins added a comment - I ran test-patch and committed this to branch 20.
        Hide
        owen.omalley Owen O'Malley added a comment -

        Why didn't you apply this to 0.21?

        Show
        owen.omalley Owen O'Malley added a comment - Why didn't you apply this to 0.21?
        Hide
        eli Eli Collins added a comment -

        Because it was already committed to the 21 branch.

        Show
        eli Eli Collins added a comment - Because it was already committed to the 21 branch.

          People

          • Assignee:
            tlipcon Todd Lipcon
            Reporter:
            tlipcon Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development