Hadoop Common
  1. Hadoop Common
  2. HADOOP-6723

unchecked exceptions thrown in IPC Connection orphan clients

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.20.2
    • Fix Version/s: 0.21.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.

      We should catch Throwable in Connection.run() and shut down the connection if we catch one.

      1. hadoop-6723.txt
        3 kB
        Todd Lipcon
      2. hadoop-6723-20-1.patch
        3 kB
        Eli Collins

        Activity

        Todd Lipcon created issue -
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hadoop-6723.txt [ 12442802 ]
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314296 ]
        Resolution Fixed [ 1 ]
        Eli Collins made changes -
        Attachment hadoop-6723-20-1.patch [ 12445499 ]
        Eli Collins made changes -
        Attachment hadoop-6723-20-1.patch [ 12445499 ]
        Eli Collins made changes -
        Attachment hadoop-6723-20-1.patch [ 12445501 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development