Hadoop Common
  1. Hadoop Common
  2. HADOOP-6703

Prevent renaming a file, symlink or directory to itself

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Per HDFS-1088 let's throw a FileAlreadyExistsException if renaming a file, symlink or directory to itself, or a symlink to the file it links to.

        Issue Links

          Activity

          Hide
          Suresh Srinivas added a comment -

          I committed the patch. Thank you Eli.

          Show
          Suresh Srinivas added a comment - I committed the patch. Thank you Eli.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - +1 for the patch.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12443017/hadoop-6703-3.patch
          against trunk revision 938590.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443017/hadoop-6703-3.patch against trunk revision 938590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/485/console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Patch attached removed the dependency on HADOOP-6563 and merges with trunk. This one just needs to go in with HDFS-1100 which has a +1.

          Show
          Eli Collins added a comment - Patch attached removed the dependency on HADOOP-6563 and merges with trunk. This one just needs to go in with HDFS-1100 which has a +1.
          Hide
          Eli Collins added a comment -

          This jira applies after HADOOP-6563 (which makes a bunch of changes to the test classes).

          Show
          Eli Collins added a comment - This jira applies after HADOOP-6563 (which makes a bunch of changes to the test classes).
          Hide
          Suresh Srinivas added a comment -

          Eli, this patch does not apply to trunk. Can you please resubmit the patch.

          Show
          Suresh Srinivas added a comment - Eli, this patch does not apply to trunk. Can you please resubmit the patch.
          Hide
          Eli Collins added a comment -

          The tests in this patch won't pass until the patch to HDFS-1100 is applied, however that patch won't compile until this change is checked in (these tests use unwrapException but require the sub-class override it).

          Show
          Eli Collins added a comment - The tests in this patch won't pass until the patch to HDFS-1100 is applied, however that patch won't compile until this change is checked in (these tests use unwrapException but require the sub-class override it).
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - +1 for the patch.
          Hide
          Eli Collins added a comment -

          Per HDFS-1088, minor update to report file names in the exceptions.

          Show
          Eli Collins added a comment - Per HDFS-1088 , minor update to report file names in the exceptions.
          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Hide
          Eli Collins added a comment -

          Need the hdfs side change for the tests to pass.

          Show
          Eli Collins added a comment - Need the hdfs side change for the tests to pass.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development