Hadoop Common
  1. Hadoop Common
  2. HADOOP-6698

Revert the io.serialization package to 0.20.2's api

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I have a lot of concern about the usability of the new generic serialization framework. Toward that end, I've filed a jira for improving it. There is resistance to pushing a new API into 0.21 at the last moment, so we should back out the changes rather than introducing a new api in 0.21 and deprecating it in 0.22.

      1. HADOOP-6698.patch
        69 kB
        Tom White
      2. HADOOP-6698.patch
        76 kB
        Tom White
      3. HADOOP-6698.patch
        76 kB
        Tom White

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          We need to revert HADOOP-6165 to achieve this.

          Show
          Tom White added a comment - We need to revert HADOOP-6165 to achieve this.
          Hide
          Doug Cutting added a comment -

          This issue is fundamentally about backing out changes related to HADOOP-1126, since you've rejected that patch. In that light, HADOOP-6420, HADOOP-6438 and HADOOP-6443 should perhaps also be backed out.

          Show
          Doug Cutting added a comment - This issue is fundamentally about backing out changes related to HADOOP-1126 , since you've rejected that patch. In that light, HADOOP-6420 , HADOOP-6438 and HADOOP-6443 should perhaps also be backed out.
          Hide
          Tom White added a comment -

          Doug, I think you mean MAPREDUCE-1126 (not HADOOP-1126). Also HADOOP-6323 needs backing out.

          Show
          Tom White added a comment - Doug, I think you mean MAPREDUCE-1126 (not HADOOP-1126 ). Also HADOOP-6323 needs backing out.
          Hide
          Tom White added a comment -

          Here's a patch which reverts all these changes.

          Show
          Tom White added a comment - Here's a patch which reverts all these changes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12442493/HADOOP-6698.patch
          against trunk revision 936463.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442493/HADOOP-6698.patch against trunk revision 936463. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/472/console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12442620/HADOOP-6698.patch
          against trunk revision 936463.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442620/HADOOP-6698.patch against trunk revision 936463. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/473/console This message is automatically generated.
          Hide
          Chris Douglas added a comment -

          This issue is fundamentally about backing out changes related to HADOOP-1126, since you've rejected that patch. In that light, HADOOP-6420, HADOOP-6438 and HADOOP-6443 should perhaps also be backed out.

          HADOOP-6420 was completed with MAPREDUCE-1126 as a use case, but it's an independent feature. Does it need to be backed out? Also, HADOOP-6438 was closed as invalid, not committed, so fortunately there's nothing to be backed out, there.

          Show
          Chris Douglas added a comment - This issue is fundamentally about backing out changes related to HADOOP-1126 , since you've rejected that patch. In that light, HADOOP-6420 , HADOOP-6438 and HADOOP-6443 should perhaps also be backed out. HADOOP-6420 was completed with MAPREDUCE-1126 as a use case, but it's an independent feature. Does it need to be backed out? Also, HADOOP-6438 was closed as invalid, not committed, so fortunately there's nothing to be backed out, there.
          Hide
          Tom White added a comment -

          The patch I submitted backs out HADOOP-6420 - should I regenerate leaving it in?

          Show
          Tom White added a comment - The patch I submitted backs out HADOOP-6420 - should I regenerate leaving it in?
          Hide
          Chris Douglas added a comment -

          The patch I submitted backs out HADOOP-6420 - should I regenerate leaving it in?

          Reverting it isn't part of this issue, but I'm +0 on retaining it. Is there another use case, other than the patch in MAPREDUCE-1126?

          Show
          Chris Douglas added a comment - The patch I submitted backs out HADOOP-6420 - should I regenerate leaving it in? Reverting it isn't part of this issue, but I'm +0 on retaining it. Is there another use case, other than the patch in MAPREDUCE-1126 ?
          Hide
          Tom White added a comment -

          Here's a new patch which doesn't revert HADOOP-6420 (we can always revert if separately, if need be).

          Show
          Tom White added a comment - Here's a new patch which doesn't revert HADOOP-6420 (we can always revert if separately, if need be).
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12442922/HADOOP-6698.patch
          against trunk revision 938264.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442922/HADOOP-6698.patch against trunk revision 938264. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/53/console This message is automatically generated.
          Hide
          Doug Cutting added a comment -

          > HADOOP-6420 was completed with MAPREDUCE-1126 as a use case, but it's an independent feature. Does it need to be backed out?

          If it has no other use cases, it should be backed out, no? If someone comes up with a use case, we can add it back, but, since it was added with MAPREDUCE-1126 as its only use case, and MAPREDUCE-1126 has stalled, I'd vote to back it out.

          Show
          Doug Cutting added a comment - > HADOOP-6420 was completed with MAPREDUCE-1126 as a use case, but it's an independent feature. Does it need to be backed out? If it has no other use cases, it should be backed out, no? If someone comes up with a use case, we can add it back, but, since it was added with MAPREDUCE-1126 as its only use case, and MAPREDUCE-1126 has stalled, I'd vote to back it out.
          Hide
          Doug Cutting added a comment -

          I should have been clearer: I'd vote to remove HADOOP-6420 as a part of this issue, since it's only current use case is to work with the serialization APIs that are being reverted in this issue.

          Show
          Doug Cutting added a comment - I should have been clearer: I'd vote to remove HADOOP-6420 as a part of this issue, since it's only current use case is to work with the serialization APIs that are being reverted in this issue.
          Hide
          Tom White added a comment -

          OK, I can remove HADOOP-6420 here. I'll commit this soon unless there are any objections.

          Show
          Tom White added a comment - OK, I can remove HADOOP-6420 here. I'll commit this soon unless there are any objections.
          Hide
          Tom White added a comment -
          Show
          Tom White added a comment - I've just committed this ( https://issues.apache.org/jira/secure/attachment/12442620/HADOOP-6698.patch ).
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12442922/HADOOP-6698.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1413//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442922/HADOOP-6698.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1413//console This message is automatically generated.

            People

            • Assignee:
              Tom White
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development