Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 0.22.0
-
Fix Version/s: 0.22.0
-
Component/s: None
-
Labels:None
-
Hadoop Flags:Reviewed
-
Release Note:New metrics "login" of type MetricTimeVaryingRate is added under new metrics context name "ugi" and metrics record name "ugi".
Description
Need metrics to track kerberos login activity such as login rate and the time taken for login.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Integrated in Hadoop-Common-trunk-Commit #359 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/359/)
HADOOP-6693. Add metrics to track kerberol login activity. Contributed by Suresh Srinivas.
I committed the patch.
Since hudson has some issues, ran the unit tests and testpatch. All the tests passed.
+1.
The kinit login in spawnAutoRenewalThreadForUserCreds is not tracked by these metrics, which is fine because this thread is spawned only at clients and purpose of these metrics is to track logins on the servers.
New patch to fix a patch merge problem
New trunk patch that incorporates additional change from HADOOP-6808.
Trunk version of the patch.
If/when there is a patch for trunk the patch in https://issues.apache.org/jira/browse/HADOOP-6808 should also be included.
+1
New patch with unnecessary debug logs removed. Tested it on cluster to ensure metrics is being updated.
20 version of the patch. I added bumping up metrics in loginUserFromKeytabAndReturnUGI also.
The login code in UserGroupInformation is repeated in many places. There is an opportunity to improve the code by making a method for it.
+1
New patch adds MetricsTimeVaryingRate metrics for login success and failure.
Also should we add metrics for logout?
Owen, MetricsTimeVaryingRate exposes two pieces of information: Number of operations and average time taken for the operation. Does it cover your requirement?
I will change the patch to include two metrics - one for tracking login success and another for login failure.
To figure out the time take for login, we also need the number of logins to divide by. I'd suggest adding the number of successes and failures for keytab logins.
Note that the new metrics is aggregated across all the nodes in the cluster, since no distinction made in metrics record name about the node where the metrics was reported from.
Patch adds new metrics "login" of type MetricTimeVaryingRate under metrics context "ugi" and metrics record "ugi".
Integrated in Hadoop-Common-trunk #427 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/427/)
HADOOP-6693. Add metrics to track kerberol login activity. Contributed by Suresh Srinivas.