Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      This jira introduces two performance improvements in Sasl RPC
      1. Setting of Sasl 'quality of protection' to authentication only.
      2. Addition of BufferedOutputStream underneath SaslOutputStream.

      1. HADOOP-6674.1.patch
        13 kB
        Jitendra Nath Pandey
      2. HADOOP-6674.2.patch
        14 kB
        Jitendra Nath Pandey
      3. HADOOP-6674-y20.1.bugfix.patch
        0.9 kB
        Devaraj Das
      4. HADOOP-6674-y20.1.bugfix.patch
        1.0 kB
        Devaraj Das
      5. HADOOP-6674-y20.1.patch
        12 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Jitendra Nath Pandey added a comment -

        Patch for 20 branch.

        Show
        Jitendra Nath Pandey added a comment - Patch for 20 branch.
        Hide
        Owen O'Malley added a comment -

        This looks good.

        Show
        Owen O'Malley added a comment - This looks good.
        Hide
        Devaraj Das added a comment -

        Attaching a patch fixing a bug. This patch is on top of the earlier patch - http://tinyurl.com/2beueg9.

        Show
        Devaraj Das added a comment - Attaching a patch fixing a bug. This patch is on top of the earlier patch - http://tinyurl.com/2beueg9 .
        Hide
        Owen O'Malley added a comment -

        Two comments:
        1. Don't bother with useSasl and just use useWrap. useWrap implies useSasl.
        2. I don't think you correctly handle the case of pings when useWrap is true.

        Show
        Owen O'Malley added a comment - Two comments: 1. Don't bother with useSasl and just use useWrap. useWrap implies useSasl. 2. I don't think you correctly handle the case of pings when useWrap is true.
        Hide
        Devaraj Das added a comment -

        Attaching a slightly modified version of the earlier patch.

        Show
        Devaraj Das added a comment - Attaching a slightly modified version of the earlier patch.
        Hide
        Devaraj Das added a comment -

        In response to Owen's comment (2), the case of pings when useWrap is true is handled within processUnwrappedData (since the Pings are also wrapped and sent from the client)

        Show
        Devaraj Das added a comment - In response to Owen's comment (2), the case of pings when useWrap is true is handled within processUnwrappedData (since the Pings are also wrapped and sent from the client)
        Hide
        Owen O'Malley added a comment -

        The new patch looks good.

        Show
        Owen O'Malley added a comment - The new patch looks good.
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for trunk.

        Show
        Jitendra Nath Pandey added a comment - Patch for trunk.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446274/HADOOP-6674.1.patch
        against trunk revision 951081.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446274/HADOOP-6674.1.patch against trunk revision 951081. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/76/console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        Some nits:
        1) The configuration hadoop.rpc.protection is missing from core-default.xml
        2) The if statements

         if (dataLength == Client.PING_CALL_ID) {
                    if(!useWrap) { 

        can be combined into a single statement.

        Show
        Devaraj Das added a comment - Some nits: 1) The configuration hadoop.rpc.protection is missing from core-default.xml 2) The if statements if (dataLength == Client.PING_CALL_ID) { if(!useWrap) { can be combined into a single statement.
        Hide
        Jitendra Nath Pandey added a comment -

        New patch addressing the comments.

        Show
        Jitendra Nath Pandey added a comment - New patch addressing the comments.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446373/HADOOP-6674.2.patch
        against trunk revision 951480.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446373/HADOOP-6674.2.patch against trunk revision 951480. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/564/console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Jitendra!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Jitendra!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #283 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/283/)
        HADOOP-6674. Makes use of the SASL authentication options in the SASL RPC. Contributed by Jitendra Pandey.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #283 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/283/ ) HADOOP-6674 . Makes use of the SASL authentication options in the SASL RPC. Contributed by Jitendra Pandey.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #357 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/357/)
        HADOOP-6674. Makes use of the SASL authentication options in the SASL RPC. Contributed by Jitendra Pandey.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #357 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/357/ ) HADOOP-6674 . Makes use of the SASL authentication options in the SASL RPC. Contributed by Jitendra Pandey.

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development