Hadoop Common
  1. Hadoop Common
  2. HADOOP-6661

User document for UserGroupInformation.doAs

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A user document should be added for secure impersonation feature. The document should cover a code example about how UserGroupInformation.doAs should be used for secure impersonation.

      1. HADOOP-6661.1.patch
        6 kB
        Jitendra Nath Pandey
      2. HADOOP-6661.2.patch
        6 kB
        Jitendra Nath Pandey
      3. HADOOP-6661.3.patch
        6 kB
        Jitendra Nath Pandey
      4. HADOOP-6661.4.patch
        6 kB
        Jitendra Nath Pandey
      5. HADOOP-6661-y20.1.patch
        5 kB
        Jitendra Nath Pandey
      6. HADOOP-6661-y20.2.patch
        5 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #356 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/356/)
        HADOOP-6661. User document for UserGroupInformation.doAs. Contributed by Jitendra Pandey.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #356 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/356/ ) HADOOP-6661 . User document for UserGroupInformation.doAs. Contributed by Jitendra Pandey.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #277 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/277/)
        HADOOP-6661. User document for UserGroupInformation.doAs. Contributed by Jitendra Pandey.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #277 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/277/ ) HADOOP-6661 . User document for UserGroupInformation.doAs. Contributed by Jitendra Pandey.
        Hide
        Jakob Homan added a comment -

        I've committed this. Thanks, Jitendra! Resolving as fixed.

        Show
        Jakob Homan added a comment - I've committed this. Thanks, Jitendra! Resolving as fixed.
        Hide
        Jakob Homan added a comment -

        +1

        Show
        Jakob Homan added a comment - +1
        Hide
        Jitendra Nath Pandey added a comment -

        New patch addressing comments.
        ant docs is tested.

        Show
        Jitendra Nath Pandey added a comment - New patch addressing comments. ant docs is tested.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446301/HADOOP-6661.3.patch
        against trunk revision 951207.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446301/HADOOP-6661.3.patch against trunk revision 951207. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/561/console This message is automatically generated.
        Hide
        Jakob Homan added a comment -

        This looks much better. The file name and TOC entry is still for secure impersonation, however.

        Show
        Jakob Homan added a comment - This looks much better. The file name and TOC entry is still for secure impersonation, however.
        Hide
        Jitendra Nath Pandey added a comment -

        New patch addressing the comment.

        Show
        Jitendra Nath Pandey added a comment - New patch addressing the comment.
        Hide
        Jakob Homan added a comment -

        I'm not wild about the use of Oozie in the example. Oozie's not yet in the code source and there's no reason documentation readers would be familiar with that project. Also, the text makes it sound as if this feature is in there for Oozie in particular. There needs to be more explanation that this is a generic feature for different types of superusers. Also, this is the only place we use the term "Secure Impersonation," which sounds like a poor word choice. What about "Superusers submitting jobs on behalf of other users"?

        Show
        Jakob Homan added a comment - I'm not wild about the use of Oozie in the example. Oozie's not yet in the code source and there's no reason documentation readers would be familiar with that project. Also, the text makes it sound as if this feature is in there for Oozie in particular. There needs to be more explanation that this is a generic feature for different types of superusers. Also, this is the only place we use the term "Secure Impersonation," which sounds like a poor word choice. What about "Superusers submitting jobs on behalf of other users"?
        Hide
        Jitendra Nath Pandey added a comment -

        ant docs was run manually to verify the patch.
        ant tests is not required because it is a new user doc only.

        Show
        Jitendra Nath Pandey added a comment - ant docs was run manually to verify the patch. ant tests is not required because it is a new user doc only.
        Hide
        Jitendra Nath Pandey added a comment -

        test patch results

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        No tests added or modified because this patch adds a user document.

        Show
        Jitendra Nath Pandey added a comment - test patch results [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. No tests added or modified because this patch adds a user document.
        Hide
        Jitendra Nath Pandey added a comment -

        Hudson couldn't apply the patch because 20 patch got submitted for hudson tests.

        Show
        Jitendra Nath Pandey added a comment - Hudson couldn't apply the patch because 20 patch got submitted for hudson tests.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12439844/HADOOP-6661-y20.1.patch
        against trunk revision 927728.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/433/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439844/HADOOP-6661-y20.1.patch against trunk revision 927728. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/433/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        20 patch is uploaded.

        Show
        Jitendra Nath Pandey added a comment - 20 patch is uploaded.

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development