Hadoop Common
  1. Hadoop Common
  2. HADOOP-6644

util.Shell getGROUPS_FOR_USER_COMMAND method name - should use common naming convention

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      util.Shell getGROUPS_FOR_USER_COMMAND method name - should use common naming convention

      1. HADOOP-6644.patch
        5 kB
        Boris Shkolnik
      2. HADOOP-6644-BP20.patch
        6 kB
        Boris Shkolnik

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #349 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/349/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #349 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/349/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #268 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/268/)
        HADOOP-6644. util.Shell getGROUPS_FOR_USER_COMMAND method name - should use common naming convention

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #268 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/268/ ) HADOOP-6644 . util.Shell getGROUPS_FOR_USER_COMMAND method name - should use common naming convention
        Hide
        Boris Shkolnik added a comment -

        committed to trunk.

        Show
        Boris Shkolnik added a comment - committed to trunk.
        Hide
        Jakob Homan added a comment -

        +1

        Show
        Jakob Homan added a comment - +1
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445561/HADOOP-6644.patch
        against trunk revision 948242.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445561/HADOOP-6644.patch against trunk revision 948242. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/547/console This message is automatically generated.
        Hide
        Boris Shkolnik added a comment -

        for previous version, not for commit

        Show
        Boris Shkolnik added a comment - for previous version, not for commit
        Hide
        Boris Shkolnik added a comment -

        also included these issues:

        • Put back the constructor for Server in Server.java
        • auditLOG should be private in Server and should be all uppercase
        Show
        Boris Shkolnik added a comment - also included these issues: Put back the constructor for Server in Server.java auditLOG should be private in Server and should be all uppercase

          People

          • Assignee:
            Boris Shkolnik
            Reporter:
            Boris Shkolnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development