Hadoop Common
  1. Hadoop Common
  2. HADOOP-6635

Install or deploy source jars to maven repo

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Publishing source jars to the local m2 cache or a public maven repo is extremely handy for Hadoop users that want to be able to inspect the Hadoop source from within their IDE.

      1. HADOOP-6635-branch-20.patch
        3 kB
        Patrick Angeles
      2. HADOOP-6635.patch
        3 kB
        Patrick Angeles

        Issue Links

          Activity

          Hide
          Patrick Angeles added a comment -

          THis patch builds on the recently committed HADOOP-6382

          Show
          Patrick Angeles added a comment - THis patch builds on the recently committed HADOOP-6382
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12439040/patch-6635.txt
          against trunk revision 923619.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/420/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439040/patch-6635.txt against trunk revision 923619. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/420/console This message is automatically generated.
          Hide
          Patrick Angeles added a comment -

          Renaming patches for clarity.

          HADOOP-6635.patch is for trunk

          HADOOP-6635-branch-20.patch is a backport for branch-0.20

          Show
          Patrick Angeles added a comment - Renaming patches for clarity. HADOOP-6635 .patch is for trunk HADOOP-6635 -branch-20.patch is a backport for branch-0.20
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12439301/HADOOP-6635.patch
          against trunk revision 923619.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439301/HADOOP-6635.patch against trunk revision 923619. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/424/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          +1. I manually tested by applying all three of the patches, generating the source jar files, verifying their contents and starting a Maven-based project in Eclipse that depended on the local versions and verifying that Eclipse pulled in the source jars as necessary. This will be a big help.

          Show
          Jakob Homan added a comment - +1. I manually tested by applying all three of the patches, generating the source jar files, verifying their contents and starting a Maven-based project in Eclipse that depended on the local versions and verifying that Eclipse pulled in the source jars as necessary. This will be a big help.
          Hide
          Jakob Homan added a comment -

          I've committed this. Thanks Patrick! Resolving as fixed.

          Show
          Jakob Homan added a comment - I've committed this. Thanks Patrick! Resolving as fixed.

            People

            • Assignee:
              Patrick Angeles
              Reporter:
              Patrick Angeles
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development