Hadoop Common
  1. Hadoop Common
  2. HADOOP-6622

Token should not print the password in toString.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The toString method in Token should not print out the password.

        Issue Links

          Activity

          Ravi Prakash made changes -
          Link This issue is cloned as HADOOP-8445 [ HADOOP-8445 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #733 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/733/)
          HADOOP-6622. Token should not print the password in toString.

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156855
          Files :

          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #733 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/733/ ) HADOOP-6622 . Token should not print the password in toString. eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156855 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Eli Collins added a comment -

          Thanks atm! I ran tests locally. I've committed this.

          Show
          Eli Collins added a comment - Thanks atm! I ran tests locally. I've committed this.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Hide
          Aaron T. Myers added a comment -

          +1, patch looks good to me.

          Show
          Aaron T. Myers added a comment - +1, patch looks good to me.
          Hide
          Eli Collins added a comment -

          Trivial change, just removes two lines.

          -1 overall.  
          
              +1 @author.  The patch does not contain any @author tags.
          
              -1 tests included.  The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.
          
              +1 javadoc.  The javadoc tool did not generate any warning messages.
          
              +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          
              +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          
              +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
              +1 system test framework.  The patch passed system test framework compile.
          
          Show
          Eli Collins added a comment - Trivial change, just removes two lines. -1 overall. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 system test framework. The patch passed system test framework compile.
          Eli Collins made changes -
          Attachment hadoop-6622-1.patch [ 12490133 ]
          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Eli Collins made changes -
          Field Original Value New Value
          Assignee Jitendra Nath Pandey [ jnp ] Eli Collins [ eli ]
          Fix Version/s 0.23.0 [ 12315569 ]
          Component/s security [ 12312526 ]
          Jitendra Nath Pandey created issue -

            People

            • Assignee:
              Eli Collins
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development