Hadoop Common
  1. Hadoop Common
  2. HADOOP-6540

Contrib unit tests have invalid XML for core-site, etc.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The *-site.xml files in src/contrib/test are not valid XML. the <?xml .. ?> declaration must appear above the license header.

      1. HADOOP-6540.patch
        3 kB
        Aaron Kimball

        Activity

        Aaron Kimball created issue -
        Hide
        Aaron Kimball added a comment -

        Attaching patch to fix this.

        Show
        Aaron Kimball added a comment - Attaching patch to fix this.
        Aaron Kimball made changes -
        Field Original Value New Value
        Attachment HADOOP-6540.patch [ 12434888 ]
        Aaron Kimball made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12434888/HADOOP-6540.patch
        against trunk revision 906388.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12434888/HADOOP-6540.patch against trunk revision 906388. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/328/console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Aaron!

        Show
        Tom White added a comment - I've just committed this. Thanks Aaron!
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314296 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #159 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/159/)
        . Contrib unit tests have invalid XML for core-site, etc. Contributed by Aaron Kimball.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #159 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/159/ ) . Contrib unit tests have invalid XML for core-site, etc. Contributed by Aaron Kimball.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #244 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/244/)
        . Contrib unit tests have invalid XML for core-site, etc. Contributed by Aaron Kimball.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #244 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/244/ ) . Contrib unit tests have invalid XML for core-site, etc. Contributed by Aaron Kimball.
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.22.0 [ 12314296 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        42s 1 Aaron Kimball 04/Feb/10 23:28
        Patch Available Patch Available Resolved Resolved
        4d 6h 35m 1 Tom White 09/Feb/10 06:04
        Resolved Resolved Closed Closed
        196d 14h 37m 1 Tom White 24/Aug/10 21:41

          People

          • Assignee:
            Aaron Kimball
            Reporter:
            Aaron Kimball
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development