Hadoop Common
  1. Hadoop Common
  2. HADOOP-6534

LocalDirAllocator should use whitespace trimming configuration getters

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: conf, fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is the other half of MAPREDUCE-1441. If a user specifies mapred.local.dir with whitespace around directory names, it should be trimmed. Same goes for any LocalDirAllocator-based configuration.

      1. hadoop-6534.txt
        0.9 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12434577/hadoop-6534.txt
          against trunk revision 904975.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12434577/hadoop-6534.txt against trunk revision 904975. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/315/console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          Don't think this needs tests of its own - the change is trivial and the method in Configuration is already tested.

          Show
          Todd Lipcon added a comment - Don't think this needs tests of its own - the change is trivial and the method in Configuration is already tested.
          Hide
          Tom White added a comment -

          +1

          Show
          Tom White added a comment - +1
          Hide
          Chris Douglas added a comment -

          +1

          I committed this. Thanks, Todd!

          Show
          Chris Douglas added a comment - +1 I committed this. Thanks, Todd!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #167 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/167/)
          . Trim whitespace from directory lists initializing
          LocalDirAllocator. Contributed by Todd Lipcon

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #167 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/167/ ) . Trim whitespace from directory lists initializing LocalDirAllocator. Contributed by Todd Lipcon
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #249 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/)
          . Trim whitespace from directory lists initializing
          LocalDirAllocator. Contributed by Todd Lipcon

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #249 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/ ) . Trim whitespace from directory lists initializing LocalDirAllocator. Contributed by Todd Lipcon

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development