Hadoop Common
  1. Hadoop Common
  2. HADOOP-6506

Failing tests prevent the rest of test targets from execution.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.20.2
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Build system of 0.20 has the problem which has been fixed in after split (i.e. past 0.20) subprojects but never been properly backported.
      During an execution of

        % ant test
      

      if a single test case gets failed say in test-core then test-contrib won't be executed at all.

      This happens because of Ant dependencies mechanism as test target depends on test-core, test-contrib

      1. HADOOP-6506.patch
        1 kB
        Konstantin Boudnik
      2. HADOOP-6506.patch
        1 kB
        Konstantin Boudnik
      3. HADOOP-6506-ydist-0.20.patch
        1 kB
        Konstantin Boudnik
      4. HADOOP-6506_0.20.patch
        2 kB
        Konstantin Boudnik
      5. HADOOP-6506-ydist-0.20.patch
        2 kB
        Konstantin Boudnik
      6. HADOOP-6506-ydist-0.20.patch
        2 kB
        Arun C Murthy

        Issue Links

          Activity

          Konstantin Boudnik created issue -
          Hide
          Konstantin Boudnik added a comment -

          This is backport of existing solution from 0.21

          Show
          Konstantin Boudnik added a comment - This is backport of existing solution from 0.21
          Konstantin Boudnik made changes -
          Field Original Value New Value
          Attachment HADOOP-6506.patch [ 12431166 ]
          Hide
          Todd Lipcon added a comment -

          Hey Konstantin. This patch doesn't seem to be against branch-20 – it references fault-inject. Am I missing something?

          Show
          Todd Lipcon added a comment - Hey Konstantin. This patch doesn't seem to be against branch-20 – it references fault-inject. Am I missing something?
          Konstantin Boudnik made changes -
          Link This issue is related to HADOOP-5457 [ HADOOP-5457 ]
          Hide
          Konstantin Boudnik added a comment -

          This patch isn't for local inclusion and depends on 0.20-ydist patch HADOOP-6204 to be present.

          Show
          Konstantin Boudnik added a comment - This patch isn't for local inclusion and depends on 0.20-ydist patch HADOOP-6204 to be present.
          Hide
          Todd Lipcon added a comment -

          I think we should target Apache branch-20 with a fix for this as well – we do have a branch-20 build on Apache hudson, and this is an easy fix that will help that out, no?

          Show
          Todd Lipcon added a comment - I think we should target Apache branch-20 with a fix for this as well – we do have a branch-20 build on Apache hudson, and this is an easy fix that will help that out, no?
          Hide
          Konstantin Boudnik added a comment -

          I agree, Todd - this is an unpleasant issue and it's better be fixed. This patch is for Apache 0.20.

          Show
          Konstantin Boudnik added a comment - I agree, Todd - this is an unpleasant issue and it's better be fixed. This patch is for Apache 0.20.
          Konstantin Boudnik made changes -
          Attachment HADOOP-6506.patch [ 12431180 ]
          Hide
          Konstantin Boudnik added a comment -

          This is slightly different patch, because it relies on HADOOP-6204 and is used for ydist-0.20 release.

          Show
          Konstantin Boudnik added a comment - This is slightly different patch, because it relies on HADOOP-6204 and is used for ydist-0.20 release.
          Konstantin Boudnik made changes -
          Attachment HADOOP-6506-ydist-0.20.patch [ 12431181 ]
          Hide
          Konstantin Boudnik added a comment -

          Would appreciate if anyone can formally review the patch for Apache 0.20 so it can be committed.

          Show
          Konstantin Boudnik added a comment - Would appreciate if anyone can formally review the patch for Apache 0.20 so it can be committed.
          Hide
          Konstantin Boudnik added a comment -

          Oops, this is the patch for 0.20 branch. It doesn't have any dependencies from other patches and can be used as is.

          I'd appreciate if someone can review this, so it can be committed.

          Show
          Konstantin Boudnik added a comment - Oops, this is the patch for 0.20 branch. It doesn't have any dependencies from other patches and can be used as is. I'd appreciate if someone can review this, so it can be committed.
          Konstantin Boudnik made changes -
          Attachment HADOOP-6506_0.20.patch [ 12431598 ]
          Hide
          Konstantin Boudnik added a comment -

          Y!dist patch representing latest Apache 0.20 branch

          Show
          Konstantin Boudnik added a comment - Y!dist patch representing latest Apache 0.20 branch
          Konstantin Boudnik made changes -
          Attachment HADOOP-6506-ydist-0.20.patch [ 12431614 ]
          Hide
          Todd Lipcon added a comment -

          Apache 0.20 patch looks good to me. +1

          Show
          Todd Lipcon added a comment - Apache 0.20 patch looks good to me. +1
          Hide
          Konstantin Boudnik added a comment -

          I have tested this locally, because there's no way to verify it through test-patch process.

          I've just committed this.

          Show
          Konstantin Boudnik added a comment - I have tested this locally, because there's no way to verify it through test-patch process. I've just committed this.
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.20.2 [ 12314203 ]
          Resolution Fixed [ 1 ]
          Hide
          Arun C Murthy added a comment -

          Updated patch for yhadoop20.

          Show
          Arun C Murthy added a comment - Updated patch for yhadoop20.
          Arun C Murthy made changes -
          Attachment HADOOP-6506-ydist-0.20.patch [ 12435760 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          5d 20h 30m 1 Konstantin Boudnik 28/Jan/10 19:31

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development