Hadoop Common
  1. Hadoop Common
  2. HADOOP-6497

Introduce wrapper around FSDataInputStream providing Avro SeekableInput interface

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Reading data from avro files requires using Avro's SeekableInput interface; we need to be able to wrap FSDataInputStream in this interface.

      1. HADOOP-6497.patch
        5 kB
        Aaron Kimball
      2. HADOOP-6497.2.patch
        5 kB
        Aaron Kimball

        Issue Links

          Activity

          Hide
          Sanjay Radia added a comment -

          Where should such wrapper classes sit?

          • fs package (as done in this patch)
          • common's util package
          • common's contrib
          • avro's contrib

          I don't think the fs package should depend on avro; in the future we may get wappers for other serialization systems.
          I think we should move this; not sure which of the above is the best home. Thoughts?

          Show
          Sanjay Radia added a comment - Where should such wrapper classes sit? fs package (as done in this patch) common's util package common's contrib avro's contrib I don't think the fs package should depend on avro; in the future we may get wappers for other serialization systems. I think we should move this; not sure which of the above is the best home. Thoughts?
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #229 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #229 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/ )
          Hide
          Doug Cutting added a comment -

          I just committed this. Thanks, Aaron!

          Show
          Doug Cutting added a comment - I just committed this. Thanks, Aaron!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12430676/HADOOP-6497.2.patch
          against trunk revision 899866.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430676/HADOOP-6497.2.patch against trunk revision 899866. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/281/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          New patch with additional constructor.

          Show
          Aaron Kimball added a comment - New patch with additional constructor.
          Hide
          Doug Cutting added a comment -

          A constructor that takes a FileContext and a Path would be useful. It would get the file's length with FileContext#getStatus(Path), then open it with FileContext#open(Path), since almost every user of this class will need to do this. This would also simplify the unit test a bit, making it a better example of how this is expected to be used.

          Show
          Doug Cutting added a comment - A constructor that takes a FileContext and a Path would be useful. It would get the file's length with FileContext#getStatus(Path), then open it with FileContext#open(Path), since almost every user of this class will need to do this. This would also simplify the unit test a bit, making it a better example of how this is expected to be used.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12430482/HADOOP-6497.patch
          against trunk revision 899866.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430482/HADOOP-6497.patch against trunk revision 899866. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/278/console This message is automatically generated.
          Hide
          Aaron Kimball added a comment -

          Here's an implementation and test case.

          Show
          Aaron Kimball added a comment - Here's an implementation and test case.

            People

            • Assignee:
              Aaron Kimball
              Reporter:
              Aaron Kimball
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development