Hadoop Common
  1. Hadoop Common
  2. HADOOP-6495

Identifier should be serialized after the password is created In Token constructor

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Identifier should be serialized after the password is created In Token constructor because createPassword method sets values in the identifier object and hence changes it.

      1. HADOOP-6495-0_20.2.patch
        1 kB
        Jitendra Nath Pandey
      2. HADOOP-6495.1.patch
        1 kB
        Jitendra Nath Pandey

        Activity

        Jitendra Nath Pandey created issue -
        Jitendra Nath Pandey made changes -
        Field Original Value New Value
        Attachment HADOOP-6495.1.patch [ 12430344 ]
        Boris Shkolnik made changes -
        Hadoop Flags [Reviewed]
        Hide
        Boris Shkolnik added a comment -

        looks good.

        Show
        Boris Shkolnik added a comment - looks good.
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12430344/HADOOP-6495.1.patch
        against trunk revision 900607.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430344/HADOOP-6495.1.patch against trunk revision 900607. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/283/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        Existing token related tests are sufficient for this patch. This patch is required to make delegation token (HDFS-899) related tests to work.

        Show
        Jitendra Nath Pandey added a comment - Existing token related tests are sufficient for this patch. This patch is required to make delegation token ( HDFS-899 ) related tests to work.
        Hide
        Boris Shkolnik added a comment -

        just committed it. Thanks Jitendra.

        Show
        Boris Shkolnik added a comment - just committed it. Thanks Jitendra.
        Jitendra Nath Pandey made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for 20 branch added

        Show
        Jitendra Nath Pandey added a comment - Patch for 20 branch added
        Jitendra Nath Pandey made changes -
        Attachment HADOOP-6495-0_20.2.patch [ 12431145 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #229 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #229 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/ )

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development