Hadoop Common
  1. Hadoop Common
  2. HADOOP-6434

Make HttpServer slightly easier to manage/diagnose faults with

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None

      Description

      It would be easier to work with HttpServer if

      1. webServer.isStarted() was exported
      2. the toString() method included the (hostname,port) in use
      3. Bind Exceptions raised in startup included the (hostname, port) requested
      1. HADOOP-6434-1.patch
        2 kB
        Steve Loughran
      2. HADOOP-6434-2.patch
        7 kB
        Steve Loughran

        Activity

        Hide
        Steve Loughran added a comment -
        1. BindExceptions include (hostname, port) while retaining old stack trace in the nested fault;
        2. toString() operator lists server state (robustly)
        3. isAlive() method is public for other bits of code to look at

        No tests, yet. I could imagine

        1. testing isAlive()
        2. testing that the toString() operator includes http://
        Show
        Steve Loughran added a comment - BindExceptions include (hostname, port) while retaining old stack trace in the nested fault; toString() operator lists server state (robustly) isAlive() method is public for other bits of code to look at No tests, yet. I could imagine testing isAlive() testing that the toString() operator includes http://
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12428161/HADOOP-6434-1.patch
        against trunk revision 891132.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428161/HADOOP-6434-1.patch against trunk revision 891132. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/209/console This message is automatically generated.
        Hide
        Tom White added a comment -

        Looks good. Marking open, pending tests.

        Show
        Tom White added a comment - Looks good. Marking open, pending tests.
        Hide
        Steve Loughran added a comment -

        Patch with tests. I've made some text constants package-public so the tests can import them: the tests will not break if you change the text.

        Again, I am fighting a losing battle with git here, and deny all responsibility if the patch does not take.

        Show
        Steve Loughran added a comment - Patch with tests. I've made some text constants package-public so the tests can import them: the tests will not break if you change the text. Again, I am fighting a losing battle with git here, and deny all responsibility if the patch does not take.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12428658/HADOOP-6434-2.patch
        against trunk revision 892113.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428658/HADOOP-6434-2.patch against trunk revision 892113. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/229/console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Steve Loughran added a comment -

        committed

        Show
        Steve Loughran added a comment - committed
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #126 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/126/)
        Make HttpServer slightly easier to manage/diagnose faults with

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #126 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/126/ ) Make HttpServer slightly easier to manage/diagnose faults with
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #197 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/197/)
        Make HttpServer slightly easier to manage/diagnose faults with

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #197 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/197/ ) Make HttpServer slightly easier to manage/diagnose faults with

          People

          • Assignee:
            Steve Loughran
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development