Details

    • Type: Task Task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      FsShell currently uses FileSystem, needs to be moved over to FileContext.

      1. HADOOP-6424.patch
        11 kB
        Karthik K
      2. HADOOP-6424.patch
        1 kB
        Bochun Bai

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          539d 16h 58m 2 Bochun Bai 15/Jun/11 02:47
          Patch Available Patch Available Open Open
          243d 15h 58m 2 Robert Joseph Evans 01/Feb/12 03:36
          Andrew Wang made changes -
          Assignee Andrew Wang [ andrew.wang ]
          Andrew Wang made changes -
          Assignee John George [ johnvijoe ] Andrew Wang [ andrew.wang ]
          Hide
          Andrew Wang added a comment -

          John George do you mind if I pick this one up? I've taken a recent interest in FileContext

          Show
          Andrew Wang added a comment - John George do you mind if I pick this one up? I've taken a recent interest in FileContext
          Andy Isaacson made changes -
          Link This issue is related to HDFS-4205 [ HDFS-4205 ]
          Colin Patrick McCabe made changes -
          Link This issue relates to HDFS-4019 [ HDFS-4019 ]
          Harsh J made changes -
          Affects Version/s 2.0.0-alpha [ 12320352 ]
          Robert Joseph Evans made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Robert Joseph Evans added a comment -

          Canceling the patch as it no longer applies to trunk

          Show
          Robert Joseph Evans added a comment - Canceling the patch as it no longer applies to trunk
          Hide
          John George added a comment -

          I think it is perfectly fine to create individual tickets for each symlink property. It might even be easier to review in that case.

          Show
          John George added a comment - I think it is perfectly fine to create individual tickets for each symlink property. It might even be easier to review in that case.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12482156/HADOOP-6424.patch
          against trunk revision 1135820.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/641//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/641//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/641//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482156/HADOOP-6424.patch against trunk revision 1135820. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/641//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/641//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/641//console This message is automatically generated.
          Bochun Bai made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Bochun Bai added a comment -

          I suggest close this issue with only FsShell.java changes. And issues blocked by this(HADOOP-6732) can start.

          Like HDFS-1788, we should create a serial of issues:
          FsShell ln: new command line to create.
          FsShell cp/mv/rm/cat/tail/stat: should support symlink as src and target.
          FsShell du: should correct size of symlink
          FsShell get/put: should support symlink.

          Is that ok?

          Show
          Bochun Bai added a comment - I suggest close this issue with only FsShell.java changes. And issues blocked by this( HADOOP-6732 ) can start. Like HDFS-1788 , we should create a serial of issues: FsShell ln: new command line to create. FsShell cp/mv/rm/cat/tail/stat: should support symlink as src and target. FsShell du: should correct size of symlink FsShell get/put: should support symlink. Is that ok?
          Bochun Bai made changes -
          Attachment HADOOP-6424.patch [ 12482156 ]
          Hide
          Bochun Bai added a comment -

          FsShell changed a lot these two years.
          More FileSystem should be removed from org.apache.hadoop.fs.shell package.

          Show
          Bochun Bai added a comment - FsShell changed a lot these two years. More FileSystem should be removed from org.apache.hadoop.fs.shell package.
          Eli Collins made changes -
          Link This issue blocks HDFS-1788 [ HDFS-1788 ]
          John George made changes -
          Assignee Kay Kay [ kaykay.unique ] John George [ johnvijoe ]
          Ravi Phulari made changes -
          Assignee Ravi Phulari [ raviphulari ] Kay Kay [ kaykay.unique ]
          Ravi Phulari made changes -
          Assignee Eli Collins [ eli ] Ravi Phulari [ raviphulari ]
          Hairong Kuang made changes -
          Link This issue blocks HADOOP-6732 [ HADOOP-6732 ]
          Tom White made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Eli Collins added a comment -

          There's no close equivalent (no cache to remove the file system from) but you're correct to process deletes where close is called though. The patch doesn't remove all the uses of FileSystem so still needs some work.

          Show
          Eli Collins added a comment - There's no close equivalent (no cache to remove the file system from) but you're correct to process deletes where close is called though. The patch doesn't remove all the uses of FileSystem so still needs some work.
          Eli Collins made changes -
          Link This issue blocks HADOOP-6446 [ HADOOP-6446 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12427559/HADOOP-6424.patch
          against trunk revision 889018.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427559/HADOOP-6424.patch against trunk revision 889018. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/186/console This message is automatically generated.
          Karthik K made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Karthik K added a comment -

          Submitted patch .

          To review:

          FsShell:close()

          { //TODO: What is the equivalent of fs.close() . Anything to do with releasing resources of FileContext ? }
          Show
          Karthik K added a comment - Submitted patch . To review: FsShell:close() { //TODO: What is the equivalent of fs.close() . Anything to do with releasing resources of FileContext ? }
          Karthik K made changes -
          Attachment HADOOP-6424.patch [ 12427559 ]
          Hide
          Karthik K added a comment -

          FsShell -> move away from FileSystem to FileContext.

          Show
          Karthik K added a comment - FsShell -> move away from FileSystem to FileContext.
          Eli Collins made changes -
          Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
          Key HDFS-817 HADOOP-6424
          Eli Collins made changes -
          Parent HDFS-765 [ 12440524 ]
          Issue Type Sub-task [ 7 ] Task [ 3 ]
          Eli Collins made changes -
          Field Original Value New Value
          Link This issue blocks HDFS-818 [ HDFS-818 ]
          Eli Collins created issue -

            People

            • Assignee:
              Unassigned
              Reporter:
              Eli Collins
            • Votes:
              1 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

              • Created:
                Updated:

                Development