> (minor) should we be really having .* imports.
These were pre-existing. The patch renames two files that included these, so the diff makes it look like new code. I attempted to change existing code as little as possible.
> -1 to logging the engine choice at info
Oops. That was for debugging and not meant to remain. I just removed it.
> This changes the signature of some public methods; so needs to be marked up as a change that is incompatible at the source level.
Yes, it does require recompilation. However the signature it changed (getProxy) is one whose result is always cast before it can be used, so no calling source code in fact needs to change, it only needs to be recompiled. We expect that folks will recompile for new releases anyway, don't we? I run 'ant clean' whenever I pull from subversion, and I don't think we generally intend for things to work for folks who don't.
> RPC.waitForProxy with a timeout needs to be public [ ... ]
> RPC.waitForProxy also needs to be interruptible [ ... ]
This patch does not change this one way or the other. These are pre-existing problems not addressed by this patch, no?