Hadoop Common
  1. Hadoop Common
  2. HADOOP-6415

Adding a common token interface for both job token and delegation token

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Both job token and delegation token will be used by RPC.

      1. c1250-17.patch
        12 kB
        Kan Zhang
      2. c1250-19.patch
        13 kB
        Kan Zhang
      3. HADOOP-6415-0_20.2.patch
        13 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12427057/c1250-17.patch
          against trunk revision 887472.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427057/c1250-17.patch against trunk revision 887472. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/console This message is automatically generated.
          Hide
          Kan Zhang added a comment -

          attached a patch that derives from an earlier draft patch of HADOOP-6373 (the Common part) and incorporates Owen's comments given there.

          Show
          Kan Zhang added a comment - attached a patch that derives from an earlier draft patch of HADOOP-6373 (the Common part) and incorporates Owen's comments given there.
          Hide
          Owen O'Malley added a comment -

          This is looking good. Some points:

          1. I'd rename convertToSecretKey to createSecretKey.
          2. You need JavaDoc entries on the public methods of Token.
          3. You need JavaDoc description of the TokenIdentifier class.
          Show
          Owen O'Malley added a comment - This is looking good. Some points: I'd rename convertToSecretKey to createSecretKey. You need JavaDoc entries on the public methods of Token. You need JavaDoc description of the TokenIdentifier class.
          Hide
          Kan Zhang added a comment -

          > I'd rename convertToSecretKey to createSecretKey.
          I named it convertToSecretKey() to emphasize the fact that the returned SecretKey is not generated locally but merely converted from the supplied byte[]. createSecretKey may mislead the user to think SecretManager contributes to the key generation in some other capacity. However, if you really like createSecretKey, I'll make the change.

          Show
          Kan Zhang added a comment - > I'd rename convertToSecretKey to createSecretKey. I named it convertToSecretKey() to emphasize the fact that the returned SecretKey is not generated locally but merely converted from the supplied byte[]. createSecretKey may mislead the user to think SecretManager contributes to the key generation in some other capacity. However, if you really like createSecretKey, I'll make the change.
          Hide
          Kan Zhang added a comment -

          Attaching a patch that addresses Owen's comments.

          Show
          Kan Zhang added a comment - Attaching a patch that addresses Owen's comments.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12428338/c1250-19.patch
          against trunk revision 891511.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428338/c1250-19.patch against trunk revision 891511. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/console This message is automatically generated.
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Kan!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Kan!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #122 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/122/)
          . Adds a common token interface for both job token and delegation token. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #122 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/122/ ) . Adds a common token interface for both job token and delegation token. Contributed by Kan Zhang.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #191 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/191/)
          . Adds a common token interface for both job token and delegation token. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #191 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/191/ ) . Adds a common token interface for both job token and delegation token. Contributed by Kan Zhang.
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for 20 branch added.

          Show
          Jitendra Nath Pandey added a comment - Patch for 20 branch added.

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development