Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      File /org/apache/hadoop/cli/testConf.xsl is not valid XML, as the <?xml?> directive comes after the comment. XML requires this to be the first thing in a file, so it can be used to determine the encoding.

        Activity

        Hide
        steve_l added a comment -

        move comment below xml declaration

        Show
        steve_l added a comment - move comment below xml declaration
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12428912/HADOOP-6402.patch
        against trunk revision 893666.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428912/HADOOP-6402.patch against trunk revision 893666. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/34/console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Steve!

        Show
        Tom White added a comment - I've just committed this. Thanks Steve!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #129 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/129/)
        . testConf.xsl is not well-formed XML. Contributed by Steve Loughran.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #129 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/129/ ) . testConf.xsl is not well-formed XML. Contributed by Steve Loughran.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #204 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/204/)
        . testConf.xsl is not well-formed XML. Contributed by Steve Loughran.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #204 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/204/ ) . testConf.xsl is not well-formed XML. Contributed by Steve Loughran.

          People

          • Assignee:
            Steve Loughran
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development