Hadoop Common
  1. Hadoop Common
  2. HADOOP-6391

Classpath should not be part of command line arguments

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Because bin/hadoop and bin/hdfs put the entire CLASSPATH in the command line arguments, it exceeds 4096 bytes, which is the maximum size that ps (or /proc) can work with. This makes looking for the processes difficult, since the output gets truncated for all components at the same point (e.g. NameNode, SecondaryNameNode, DataNode).

      The mapred sub-project does not have this problem, because it calls "export CLASSPATH" before the final exec. bin/hadoop and bin/hdfs should do the same thing

      1. HADOOP-6391.patch
        0.8 kB
        Cristian Ivascu

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #188 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/188/)
          . Classpath should not be part of command line arguments. Contributed by Cristian Ivascu.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #188 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/188/ ) . Classpath should not be part of command line arguments. Contributed by Cristian Ivascu.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #111 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/111/)
          . Classpath should not be part of command line arguments. Contributed by Cristian Ivascu.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #111 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/111/ ) . Classpath should not be part of command line arguments. Contributed by Cristian Ivascu.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Cristian!

          Show
          Tom White added a comment - I've just committed this. Thanks Cristian!
          Hide
          Amareshwari Sriramadasu added a comment -

          +1

          Show
          Amareshwari Sriramadasu added a comment - +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12426117/HADOOP-6391.patch
          against trunk revision 883206.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426117/HADOOP-6391.patch against trunk revision 883206. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/147/console This message is automatically generated.
          Hide
          Cristian Ivascu added a comment -

          no tests are included because there is no framework to test for changes in the hadoop starting scripts.

          Show
          Cristian Ivascu added a comment - no tests are included because there is no framework to test for changes in the hadoop starting scripts.

            People

            • Assignee:
              Cristian Ivascu
              Reporter:
              Cristian Ivascu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development