Hadoop Common
  1. Hadoop Common
  2. HADOOP-6347

run-test-core-fault-inject runs a test case twice if -Dtestcase is set

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a testcase is specified through -Dtestcase= and run-test-core-fault-inject is executed then the same test case is ran twice. Apparently it has to be executed only one time.

      Also, it seems to be excessive to search for a fault injection test when run-fault-inject-with-testcaseonly is executed.

      1. HADOOP-6347.patch
        2 kB
        Konstantin Boudnik
      2. HADOOP-6347.patch
        2 kB
        Konstantin Boudnik
      3. HADOOP-6347.patch
        2 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          This patch fixes both problems.

          Show
          Konstantin Boudnik added a comment - This patch fixes both problems.
          Hide
          Konstantin Boudnik added a comment -

          A better one: makes injection compilation target depends on a special wrapper target which should be customized in any subprojects.

          Show
          Konstantin Boudnik added a comment - A better one: makes injection compilation target depends on a special wrapper target which should be customized in any subprojects.
          Hide
          Jakob Homan added a comment -

          Before patch:

          [6980]shinytardis:hadoop-common(r6347) jhoman$ ant -Dtestcase=TestDU clean test | grep Running
              [junit] Running org.apache.hadoop.fs.TestDU
              [junit] Running org.apache.hadoop.fs.TestDU

          After patch:

          [6985]shinytardis:hadoop-common(r6347) jhoman$ ant -Dtestcase=TestDU clean test | grep Running
              [junit] Running org.apache.hadoop.fs.TestDU
          

          Looks good. +1.

          Show
          Jakob Homan added a comment - Before patch: [6980]shinytardis:hadoop-common(r6347) jhoman$ ant -Dtestcase=TestDU clean test | grep Running [junit] Running org.apache.hadoop.fs.TestDU [junit] Running org.apache.hadoop.fs.TestDU After patch: [6985]shinytardis:hadoop-common(r6347) jhoman$ ant -Dtestcase=TestDU clean test | grep Running [junit] Running org.apache.hadoop.fs.TestDU Looks good. +1.
          Hide
          Konstantin Boudnik added a comment -

          A comment is added to ease dependencies tracking.

          Show
          Konstantin Boudnik added a comment - A comment is added to ease dependencies tracking.
          Hide
          Konstantin Boudnik added a comment -

          Ready for a verification rounds

          Show
          Konstantin Boudnik added a comment - Ready for a verification rounds
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12423854/HADOOP-6347.patch
          against trunk revision 831478.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423854/HADOOP-6347.patch against trunk revision 831478. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/122/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          New comments are fine. +1 on updated patch.

          Show
          Jakob Homan added a comment - New comments are fine. +1 on updated patch.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #79 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/79/)
          . run-test-core-fault-inject runs a test case twice if -Dtestcase is set. Contributed by Konstantin Boudnik

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #79 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/79/ ) . run-test-core-fault-inject runs a test case twice if -Dtestcase is set. Contributed by Konstantin Boudnik
          Hide
          Konstantin Boudnik added a comment -

          Thanks for the review, Jakob!
          I have just committed this.

          Show
          Konstantin Boudnik added a comment - Thanks for the review, Jakob! I have just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/147/)
          . run-test-core-fault-inject runs a test case twice if -Dtestcase is set. Contributed by Konstantin Boudnik

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/147/ ) . run-test-core-fault-inject runs a test case twice if -Dtestcase is set. Contributed by Konstantin Boudnik

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development