[HADOOP-6345] Refactor Trash::moveToTrash() and its accompanying poor tests

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.20.1
• Component/s: fs
• Hadoop Flags: Incompatible change
• Release Note: Changes moveToTrash to only return false when trash is disabled; all other errors result in IOException. Added functional unit tests for moveToTrash() to cover major exit paaths.
• Assignee: Matt Ahrens
• Reporter: Jakob Homan
• Created: 29/Oct/09 22:48
• Updated: 02/Jun/11 17:49

Description

We've had several issues relating to the Trash and its access via the shell, none of which were picked up by the unit tests. The current moveToTrash method has 8 different ways it can terminate and sometimes uses a false value and sometimes uses an exception to indicate failure. This method should be refactored to improve readability and testability, and new tests written to exercise all possible code paths.

Issue Links

• relates to: HADOOP-6344 rm and rmr fail to correctly move the user's files to the trash prior to deleting when they are over quota.
• relates to: HADOOP-7175 Add isEnabled() to Trash
• relates to: HADOOP-7284 Trash and shell's rm does not work for viewfs