Hadoop Common
  1. Hadoop Common
  2. HADOOP-6341

Hudson giving a +1 though no tests are included.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None

      Description

      An example here. We should revert to -1 overall, otherwise, there's a real chance developers will miss giving a justification.

      1. hadoop-6341.patch
        0.4 kB
        Giridharan Kesavan

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #133 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/133/)
        . Fix test-patch.sh for checkTests function. ( gkesavan )

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #133 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/133/ ) . Fix test-patch.sh for checkTests function. ( gkesavan )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #148 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/148/)
        . Fix test-patch.sh for checkTests function. ( gkesavan )

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #148 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/148/ ) . Fix test-patch.sh for checkTests function. ( gkesavan )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #108 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/108/)
        . Fix test-patch.sh for checkTests function. ( gkesavan )

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #108 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/108/ ) . Fix test-patch.sh for checkTests function. ( gkesavan )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #97 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/97/)
        . Fix test-patch.sh for checkTests function. ( gkesavan )

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #97 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/97/ ) . Fix test-patch.sh for checkTests function. ( gkesavan )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #81 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/81/)
        . Fix test-patch.sh for checkTests function. ( gkesavan )

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #81 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/81/ ) . Fix test-patch.sh for checkTests function. ( gkesavan )
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423945/hadoop-6341.patch
        against trunk revision 832590.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/125/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423945/hadoop-6341.patch against trunk revision 832590. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/125/console This message is automatically generated.
        Hide
        Lee Tucker added a comment -

        Looks pretty good to me. +1

        Show
        Lee Tucker added a comment - Looks pretty good to me. +1
        Hide
        Giridharan Kesavan added a comment -

        changed the jira component to build

        Show
        Giridharan Kesavan added a comment - changed the jira component to build
        Hide
        Tsz Wo Nicholas Sze added a comment -

        This bug should belong test-patch.sh.

        Show
        Tsz Wo Nicholas Sze added a comment - This bug should belong test-patch.sh.
        Hide
        Hemanth Yamijala added a comment -

        I opened this in Common because I believe the script is the same across all the projects. If someone who knows more thinks this is wrong, can it please be moved to MapReduce where I noticed the problem ?

        Show
        Hemanth Yamijala added a comment - I opened this in Common because I believe the script is the same across all the projects. If someone who knows more thinks this is wrong, can it please be moved to MapReduce where I noticed the problem ?

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Hemanth Yamijala
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development