Hadoop Common
  1. Hadoop Common
  2. HADOOP-6337

Update FilterInitializer class to be more visible and take a conf for further development

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the FilterInitializer class, used to filter access to the Hadoop web interfaces, has its main method, initFilter, set to package private. This means that any classes wishing to implement this type must be in the same package. This should be public so FilterInitializers can reside in other packages.

      Also, currently all parameters to the FilterInitializer must be provided at compile time (or via a different configuration method). It would be better if the FilterInitalizer::initFilter received a Configuration parameter so it can pull conf values out at run-time. Alternatively, the class could implement Configured, but that seems heavier than is needed at this point.

      1. HADOOP-6337-Y.patch
        3 kB
        Jakob Homan
      2. HADOOP-6337.patch
        3 kB
        Jakob Homan

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1h 2m 1 Jakob Homan 27/Oct/09 23:50
        Patch Available Patch Available Resolved Resolved
        9d 21h 4m 1 Devaraj Das 06/Nov/09 20:55
        Resolved Resolved Closed Closed
        290d 23h 45m 1 Tom White 24/Aug/10 21:40
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.22.0 [ 12314296 ]
        Jakob Homan made changes -
        Attachment HADOOP-6337-Y.patch [ 12434547 ]
        Hide
        Jakob Homan added a comment -

        Updated patch for Y! version, previous was missing a public declaration.

        Show
        Jakob Homan added a comment - Updated patch for Y! version, previous was missing a public declaration.
        Jakob Homan made changes -
        Attachment HADOOP-6337-Y.patch [ 12434503 ]
        Jakob Homan made changes -
        Attachment HADOOP-6337-Y.patch [ 12434503 ]
        Hide
        Jakob Homan added a comment -

        Attaching patch for Y! 20 distribution.

        Show
        Jakob Homan added a comment - Attaching patch for Y! 20 distribution.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #151 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/151/)
        . Updates FilterInitializer class to be more visible, and the init of the class is made to take a Configuration argument. Contributed by Jakob Homan.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #151 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/151/ ) . Updates FilterInitializer class to be more visible, and the init of the class is made to take a Configuration argument. Contributed by Jakob Homan.
        Devaraj Das made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Jakob!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Jakob!
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423376/HADOOP-6337.patch
        against trunk revision 829289.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423376/HADOOP-6337.patch against trunk revision 829289. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/107/console This message is automatically generated.
        Jakob Homan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jakob Homan added a comment -

        submitting patch

        Show
        Jakob Homan added a comment - submitting patch
        Jakob Homan made changes -
        Field Original Value New Value
        Attachment HADOOP-6337.patch [ 12423376 ]
        Hide
        Jakob Homan added a comment -

        Patch with changes:

        • Update FilterInitializer class
        • Update test cases that test FilterInitializer
        • Update where filters are initialized in http server.

        No new tests as very difficult to test these changes. Manually verified that can now create a FilterInitializer in another package and that the new param is seen.

        Show
        Jakob Homan added a comment - Patch with changes: Update FilterInitializer class Update test cases that test FilterInitializer Update where filters are initialized in http server. No new tests as very difficult to test these changes. Manually verified that can now create a FilterInitializer in another package and that the new param is seen.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 the proposal sounds good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 the proposal sounds good.
        Jakob Homan created issue -

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development