Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.2, 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The JvmMetrics currently publish memory usage from the MemoryMXBean. This is useful, but doesn't include the total heap size (eg as displayed in the JT Web UI).

      It would be nice to expose Runtime.getRuntime().maxMemory() as part of JvmMetrics.

      It seems that Runtime.getRuntime().totalMemory() (used by the JT for "memory used") is the same as the 'memHeapCommittedM' which already exists.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #122 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/122/)
        . Add Runtime::maxMemory to JVM metrics. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #122 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/122/ ) . Add Runtime::maxMemory to JVM metrics. Contributed by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #56 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/56/)
        . Add Runtime::maxMemory to JVM metrics. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #56 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/56/ ) . Add Runtime::maxMemory to JVM metrics. Contributed by Todd Lipcon
        Hide
        Chris Douglas added a comment -

        +1

        I committed this. Thanks, Todd!

        Show
        Chris Douglas added a comment - +1 I committed this. Thanks, Todd!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12420321/hadoop-6279.txt
        against trunk revision 817823.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420321/hadoop-6279.txt against trunk revision 817823. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/63/console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Does not include unit tests - this is an existing open issue HADOOP-3634. This patch is a one-liner, though.

        Manual verification steps:
        1) Launch daemon with NoEmitMetricsContext configured in hadoop-metrics.properties
        2) Go to /metrics on web UI
        3) Verify totalMemoryM is present

        Show
        Todd Lipcon added a comment - Does not include unit tests - this is an existing open issue HADOOP-3634 . This patch is a one-liner, though. Manual verification steps: 1) Launch daemon with NoEmitMetricsContext configured in hadoop-metrics.properties 2) Go to /metrics on web UI 3) Verify totalMemoryM is present

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development