Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The ivy/ivy-2.0.0-rc2.jar is fetched automatically by ant, so it should be ignored by version control. Since many people use git, we should add it to the .gitignore file

      1. hadoop-6268.txt
        0.5 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Trivial patch attached

          Show
          Todd Lipcon added a comment - Trivial patch attached
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12419940/hadoop-6268.txt
          against trunk revision 816398.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419940/hadoop-6268.txt against trunk revision 816398. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/6/console This message is automatically generated.
          Hide
          Jordà Polo added a comment -

          This report is basically the same as HADOOP-5992, except that the latter doesn't provide a patch.
          The proposed .gitignore in HADOOP-5992, though, is the same as svn's svn:ignore (ivi/ivy*.jar instead of ivy/ivy-2.0.0-rc2.jar).

          Show
          Jordà Polo added a comment - This report is basically the same as HADOOP-5992 , except that the latter doesn't provide a patch. The proposed .gitignore in HADOOP-5992 , though, is the same as svn's svn:ignore (ivi/ivy*.jar instead of ivy/ivy-2.0.0-rc2.jar).
          Hide
          Chris Douglas added a comment -

          +1

          I committed this. Thanks, Todd!

          Show
          Chris Douglas added a comment - +1 I committed this. Thanks, Todd!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #37 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/37/)
          . Add ivy jar to .gitignore. Contributed by Todd Lipcon

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #37 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/37/ ) . Add ivy jar to .gitignore. Contributed by Todd Lipcon
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #101 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/101/)
          . Add ivy jar to .gitignore. Contributed by Todd Lipcon

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #101 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/101/ ) . Add ivy jar to .gitignore. Contributed by Todd Lipcon

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development