Hadoop Common
  1. Hadoop Common
  2. HADOOP-6192

Shell.getUlimitMemoryCommand is tied to Map-Reduce

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.21.0
    • Component/s: util
    • Labels:
      None

      Description

      Currently org.apache.hadoop.util.Shell.getUlimitMemoryCommand relies on a MAPREDUCE specific configuration property for the memory limit. We should break the link.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          3m 37s 1 Arun C Murthy 13/Aug/09 23:34
          Patch Available Patch Available Resolved Resolved
          8h 41m 1 Arun C Murthy 14/Aug/09 08:16
          Resolved Resolved Closed Closed
          375d 12h 22m 1 Tom White 24/Aug/10 20:39
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #55 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/55/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #55 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/55/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #49 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/49/)
          . Fix Shell.getUlimitMemoryCommand to not rely on Map-Reduce specific configs.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #49 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/49/ ) . Fix Shell.getUlimitMemoryCommand to not rely on Map-Reduce specific configs.
          Arun C Murthy made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Arun C Murthy added a comment -

          I just committed this.

          Show
          Arun C Murthy added a comment - I just committed this.
          Hide
          Chris Douglas added a comment -

          +1 (w/ testcases in MAPREDUCE-478 )

          Show
          Chris Douglas added a comment - +1 (w/ testcases in MAPREDUCE-478 )
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12416504/HADOOP-6192_0_20090813.patch
          against trunk revision 803296.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12416504/HADOOP-6192_0_20090813.patch against trunk revision 803296. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/603/console This message is automatically generated.
          Arun C Murthy made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 0.20.0 [ 12313438 ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Arun C Murthy made changes -
          Attachment HADOOP-6192_0_20090813.patch [ 12416504 ]
          Hide
          Arun C Murthy added a comment -

          Straight-forward patch. I'm adding test-cases via MAPREDUCE-478.

          Show
          Arun C Murthy added a comment - Straight-forward patch. I'm adding test-cases via MAPREDUCE-478 .
          Arun C Murthy made changes -
          Field Original Value New Value
          Link This issue blocks MAPREDUCE-478 [ MAPREDUCE-478 ]
          Arun C Murthy created issue -

            People

            • Assignee:
              Arun C Murthy
              Reporter:
              Arun C Murthy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development