Hadoop Common
  1. Hadoop Common
  2. HADOOP-6182

Adding Apache License Headers and reduce releaseaudit warnings to zero

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As of now rats tool shows 111 RA warnings

      [rat:report] Summary
      [rat:report] -------
      [rat:report] Notes: 18
      [rat:report] Binaries: 118
      [rat:report] Archives: 33
      [rat:report] Standards: 942
      [rat:report]
      [rat:report] Apache Licensed: 820
      [rat:report] Generated Documents: 11
      [rat:report]
      [rat:report] JavaDocs are generated and so license header is optional
      [rat:report] Generated files do not required license headers
      [rat:report]
      [rat:report] 111 Unknown Licenses
      [rat:report]
      [rat:report] *******************************

      1. Hadoop-6182.patch
        34 kB
        Giridharan Kesavan
      2. hadoop-6182.patch
        34 kB
        Lee Tucker
      3. hadoop-6182.patch
        34 kB
        Giridharan Kesavan

        Activity

        Hide
        Giridharan Kesavan added a comment -

        with this patch the releaseaudit warnings is down to 1.

        [rat:report] 1 Unknown Licenses
        [rat:report] *******************************
        [rat:report] Unapproved licenses:
        [rat:report] src/java/org/apache/hadoop/fs/LengthFileChecksum.java

        LengthFileChecksum.java this is an empty file. I'm not sure why we have this empty java files.
        If we can remove this empty java file, we can get rid of this releaaseaudit warning.

        Thanks,

        Show
        Giridharan Kesavan added a comment - with this patch the releaseaudit warnings is down to 1. [rat:report] 1 Unknown Licenses [rat:report] ******************************* [rat:report] Unapproved licenses: [rat:report] src/java/org/apache/hadoop/fs/LengthFileChecksum.java LengthFileChecksum.java this is an empty file. I'm not sure why we have this empty java files. If we can remove this empty java file, we can get rid of this releaaseaudit warning. Thanks,
        Hide
        Tom White added a comment -

        Looks like LengthFileChecksum was removed in HADOOP-3981, although the source file wasn't deleted. It should be possible to delete it since it is no longer used. It should be deleted from the 0.20 branch too.

        Show
        Tom White added a comment - Looks like LengthFileChecksum was removed in HADOOP-3981 , although the source file wasn't deleted. It should be possible to delete it since it is no longer used. It should be deleted from the 0.20 branch too.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12416182/Hadoop-6182.patch
        against trunk revision 802224.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 60 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12416182/Hadoop-6182.patch against trunk revision 802224. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 60 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/598/console This message is automatically generated.
        Hide
        Nigel Daley added a comment -

        +1 code review.

        Show
        Nigel Daley added a comment - +1 code review.
        Hide
        Giridharan Kesavan added a comment -

        Thanks Nigel, I just committed this!

        Show
        Giridharan Kesavan added a comment - Thanks Nigel, I just committed this!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #49 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/49/)
        . Fix releaseaudit warnings by adding AL Headers.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #49 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/49/ ) . Fix releaseaudit warnings by adding AL Headers.
        Hide
        Arun C Murthy added a comment -

        I've had to revert this patch, it causes all unit-tests to fail since some of the xml config files are invalidated by the presence of the license headers (e.g. HADOOP-6195).

        This patch shouldn't have been committed since hudson did catch the problem...

        Show
        Arun C Murthy added a comment - I've had to revert this patch, it causes all unit-tests to fail since some of the xml config files are invalidated by the presence of the license headers (e.g. HADOOP-6195 ). This patch shouldn't have been committed since hudson did catch the problem...
        Hide
        Lee Tucker added a comment -

        Looks like the original patch inserted text blocks into the XML files ahead of the block:

        <?xml version="1.0"?>
        <?xml-stylesheet type="text/xsl" href="configuration.xsl"?>

        I corrected this for checkstyle in HADOOP-6185, but because the error is pervasive, it fails a wide variety of unit tests.

        Show
        Lee Tucker added a comment - Looks like the original patch inserted text blocks into the XML files ahead of the block: <?xml version="1.0"?> <?xml-stylesheet type="text/xsl" href="configuration.xsl"?> I corrected this for checkstyle in HADOOP-6185 , but because the error is pervasive, it fails a wide variety of unit tests.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > Looks like LengthFileChecksum was removed in HADOOP-3981, although the source file wasn't deleted. ...
        Let's remove the file separately once the build is stable.

        Show
        Tsz Wo Nicholas Sze added a comment - > Looks like LengthFileChecksum was removed in HADOOP-3981 , although the source file wasn't deleted. ... Let's remove the file separately once the build is stable.
        Hide
        Lee Tucker added a comment -

        Updated the patch, and moved the XML comment blocks so that they function correctly.

        Show
        Lee Tucker added a comment - Updated the patch, and moved the XML comment blocks so that they function correctly.
        Hide
        Lee Tucker added a comment -

        Ran Test-patch locally:

        [exec]
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 60 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec]
        [exec]
        [exec]
        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Finished build.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]

        Also ran unit tests and all passed.

        Show
        Lee Tucker added a comment - Ran Test-patch locally: [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 60 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] Also ran unit tests and all passed.
        Hide
        Lee Tucker added a comment -

        This adjusts the previous version of the patch to put the commented license in the appropriate location in all XML files.

        Show
        Lee Tucker added a comment - This adjusts the previous version of the patch to put the commented license in the appropriate location in all XML files.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > > Looks like LengthFileChecksum was removed in HADOOP-3981, although the source file wasn't deleted. ...
        > Let's remove the file separately once the build is stable.

        Trunk is passing the unit tests (see build #604).
        I have removed src/core/org/apache/hadoop/fs/LengthFileChecksum.java from 0.19 and above.

        Show
        Tsz Wo Nicholas Sze added a comment - > > Looks like LengthFileChecksum was removed in HADOOP-3981 , although the source file wasn't deleted. ... > Let's remove the file separately once the build is stable. Trunk is passing the unit tests (see build #604 ). I have removed src/core/org/apache/hadoop/fs/LengthFileChecksum.java from 0.19 and above.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12416590/hadoop-6182.patch
        against trunk revision 804352.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 60 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12416590/hadoop-6182.patch against trunk revision 804352. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 60 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/606/console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #55 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/55/)
        Reverting and HADOOP-6195

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #55 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/55/ ) Reverting and HADOOP-6195
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #50 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/50/)
        Reverting and HADOOP-6195

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #50 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/50/ ) Reverting and HADOOP-6195
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12416660/hadoop-6182.patch
        against trunk revision 804352.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 60 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12416660/hadoop-6182.patch against trunk revision 804352. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 60 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/607/console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #57 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/57/)
        . Fix ReleaseAudit warnings. Contributed by Giridharan Kesavan and Lee Tucker

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #57 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/57/ ) . Fix ReleaseAudit warnings. Contributed by Giridharan Kesavan and Lee Tucker
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #52 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/52/)
        . Fix ReleaseAudit warnings. Contributed by Giridharan Kesavan and Lee Tucker

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #52 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/52/ ) . Fix ReleaseAudit warnings. Contributed by Giridharan Kesavan and Lee Tucker

          People

          • Assignee:
            Giridharan Kesavan
            Reporter:
            Giridharan Kesavan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development