Hadoop Common
  1. Hadoop Common
  2. HADOOP-6176

Adding a couple private methods to AccessTokenHandler for testing purposes

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      To support some test cases being added as part of HDFS-409, a couple private methods need to be added to AccessTokenHandler. One is for setting token lifetime and another is checking if a token has expired.

      1. core-03.patch
        4 kB
        Kan Zhang
      2. HADOOP-6176-0_20.2.patch
        4 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Kan Zhang created issue -
          Kan Zhang made changes -
          Field Original Value New Value
          Component/s security [ 12312526 ]
          Kan Zhang made changes -
          Link This issue blocks HDFS-409 [ HDFS-409 ]
          Kan Zhang made changes -
          Attachment core-03.patch [ 12415521 ]
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Kan Zhang made changes -
          Summary Adding a couple private methods to AccessTokenHandler for testing puposes Adding a couple private methods to AccessTokenHandler for testing purposes
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12415521/core-03.patch
          against trunk revision 800919.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12415521/core-03.patch against trunk revision 800919. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/592/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          +1 with a readability nit: it may be nice to explicitly state in a comment that the tests are needed to expose otherwise private methods for testing. May be a reasonable assumption to make on the reader's part, but clarity is always a good thing.

          Show
          Jakob Homan added a comment - +1 with a readability nit: it may be nice to explicitly state in a comment that the tests are needed to expose otherwise private methods for testing. May be a reasonable assumption to make on the reader's part, but clarity is always a good thing.
          Hide
          Konstantin Boudnik added a comment -

          There was an idea to express the essence of this modification via aspects. However, in order to deliver this functionality in a most timely manner this effort will be carried on separately. I might be filing a separate JIRA for it if a preliminary investigation will show that such approach is viable.

          Show
          Konstantin Boudnik added a comment - There was an idea to express the essence of this modification via aspects. However, in order to deliver this functionality in a most timely manner this effort will be carried on separately. I might be filing a separate JIRA for it if a preliminary investigation will show that such approach is viable.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Kan!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Kan!
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12313563 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #48 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/48/)
          . Add a couple package private methods to AccessTokenHandler for testing. Contributed by Kan Zhang

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #48 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/48/ ) . Add a couple package private methods to AccessTokenHandler for testing. Contributed by Kan Zhang
          Konstantin Boudnik made changes -
          Link This issue is related to HADOOP-6197 [ HADOOP-6197 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6176-0_20.2.patch [ 12428771 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for hadoop 20 is added.

          Show
          Jitendra Nath Pandey added a comment - Patch for hadoop 20 is added.
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development