Hadoop Common
  1. Hadoop Common
  2. HADOOP-6163

Progress class should provide an api if phases exist

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: util
    • Labels:
      None

      Description

      Progress class needs to provide an api for client to know if there are phases.
      This is needed for Task.setProgress() to decide whether to update progress of task or progress of current phase in the task.

      1. HADOOP-6163.patch
        0.5 kB
        Ravi Gummadi
      2. HADOOP-6163.v1.patch
        0.8 kB
        Ravi Gummadi

        Issue Links

          Activity

          Hide
          Ravi Gummadi added a comment -

          This issue blocks MAPREDUCE-743.

          Show
          Ravi Gummadi added a comment - This issue blocks MAPREDUCE-743 .
          Hide
          Ravi Gummadi added a comment -

          Attaching patch that adds boolean phasesExist() method to Progress.java.

          Please review and provide your comments.

          Show
          Ravi Gummadi added a comment - Attaching patch that adds boolean phasesExist() method to Progress.java. Please review and provide your comments.
          Hide
          Ravi Gummadi added a comment -

          Attaching new patch that checks if phases exist in phase() method and returns null if there are no phases in this Progress object instead of throwing ArrayIndexOutOfBoundsException.

          Show
          Ravi Gummadi added a comment - Attaching new patch that checks if phases exist in phase() method and returns null if there are no phases in this Progress object instead of throwing ArrayIndexOutOfBoundsException.
          Hide
          Ravi Gummadi added a comment -

          ant tet-patch gave

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

          This doesn't need a testcase as the testcase in MAPREDUCE-743 covers this code change.

          Show
          Ravi Gummadi added a comment - ant tet-patch gave [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. This doesn't need a testcase as the testcase in MAPREDUCE-743 covers this code change.
          Hide
          Ravi Gummadi added a comment -

          Unit tests passed on my local machine.

          Show
          Ravi Gummadi added a comment - Unit tests passed on my local machine.
          Hide
          Ravi Gummadi added a comment -

          As we don't have tasks without phases(both map tasks and reduce tasks have phases) for which we need progress, this is not an issue.

          Show
          Ravi Gummadi added a comment - As we don't have tasks without phases(both map tasks and reduce tasks have phases) for which we need progress, this is not an issue.

            People

            • Assignee:
              Ravi Gummadi
              Reporter:
              Ravi Gummadi
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development