Hadoop Common
  1. Hadoop Common
  2. HADOOP-6141

hadoop 0.20 branch "test-patch" is broken

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.0
    • Fix Version/s: 0.20.1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There were two problems found in src/test/bin/test-patch.sh while I am doing the backporting of TFile patch (HADOOP-3315):

      • java5.home and forrest.home is not defined for the ant command in pre-build stage, which leads to the following error message (in file trunkJavacWarnings.txt):
        java5.check:
        
        BUILD FAILED
        /home/htang/workspace/test-patch/branch-0.20/build.xml:891: 'java5.home' is not defined.  Forrest requires Java 5.  Please pass -Djava5.home=<base of Java 5 distribution> to Ant on the command-line.
        
      • When referring 10-th argument from the command line, it should use "$ {10}

        " instead of "$10" (which is $1 with a zero appended).

        Activity

        Hong Tang created issue -
        Hide
        Hong Tang added a comment -

        Note that the problems in test-patch.sh seem to be fixed in trunk, but interestingly it is not backported to 0.20.

        Show
        Hong Tang added a comment - Note that the problems in test-patch.sh seem to be fixed in trunk, but interestingly it is not backported to 0.20.
        Hong Tang made changes -
        Field Original Value New Value
        Attachment hadoop-6141.patch [ 12413172 ]
        Hide
        Hong Tang added a comment -

        Added java5.home and forrest.home definitions to all ant commands. Added curly braces for $

        {10}

        (JAVA5_HOME).

        Show
        Hong Tang added a comment - Added java5.home and forrest.home definitions to all ant commands. Added curly braces for $ {10} (JAVA5_HOME).
        Hong Tang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.20.0 [ 12313438 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this to 0.20 only. Thanks, Hong!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this to 0.20 only. Thanks, Hong!
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.20.1 [ 12313866 ]
        Fix Version/s 0.20.0 [ 12313438 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Hong Tang
            Reporter:
            Hong Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development