Hadoop Common
  1. Hadoop Common
  2. HADOOP-6131

A sysproperty should not be set unless the property is set on the ant command line in build.xml.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Patch for HADOOP-3315 contains an improper usage of setting a sysproperty. What it does now:

            <sysproperty key="io.compression.codec.lzo.class"
                value="${io.compression.codec.lzo.class}"/>
      

      What should be:

       
           <syspropertyset dynamic="no">
               <propertyref name="io.compression.codec.lzo.class"/>
            </syspropertyset>
      

        Activity

        Hong Tang created issue -
        Hong Tang made changes -
        Field Original Value New Value
        Assignee Hong Tang [ hong.tang ]
        Hong Tang made changes -
        Attachment hadoop-6131.patch [ 12412848 ]
        Hide
        Hong Tang added a comment -

        Attached patch made the minor changes to build.xml. No test necessary.

        Show
        Hong Tang added a comment - Attached patch made the minor changes to build.xml. No test necessary.
        Hong Tang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12412848/hadoop-6131.patch
        against trunk revision 791937.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12412848/hadoop-6131.patch against trunk revision 791937. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/557/console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        1 to the patch. the -1 from tests is because hudson is running create-c+-configure which isnt a target in common.

         [exec] /home/hudson/tools/ant/latest/bin/ant -Dversion=791937_HADOOP-6131_PATCH-12412848 -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=/home/nigel/tools/forrest/latest -Djava5.home=/home/hudson/tools/java/latest1.5 create-c++-configure test-core 
        
        Show
        Mahadev konar added a comment - 1 to the patch. the -1 from tests is because hudson is running create-c +-configure which isnt a target in common. [exec] /home/hudson/tools/ant/latest/bin/ant -Dversion=791937_HADOOP-6131_PATCH-12412848 -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes -Dcompile.c++=yes -Dforrest.home=/home/nigel/tools/forrest/latest -Djava5.home=/home/hudson/tools/java/latest1.5 create-c++-configure test-core
        Hide
        Mahadev konar added a comment -

        +1 for the patch I meant...

        Show
        Mahadev konar added a comment - +1 for the patch I meant...
        Hide
        Mahadev konar added a comment -

        I just committed this. thanks hong.

        Show
        Mahadev konar added a comment - I just committed this. thanks hong.
        Mahadev konar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #21 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/21/)
        . A sysproperty should not be set unless the property is set on the ant command line in build.xml (hong tang via mahadev)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #21 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/21/ ) . A sysproperty should not be set unless the property is set on the ant command line in build.xml (hong tang via mahadev)
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Hong Tang
            Reporter:
            Hong Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development