Hadoop Common
  1. Hadoop Common
  2. HADOOP-6079

In DataTransferProtocol, the serialization of proxySource is not consistent

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In DataTransferProtocol.OP_REPLACE_BLOCK, proxySource is written as BalancerDatanode but then the serialized value is read as a DatanodeInfo.

      1. 6079_20090618.patch
        2 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        6079_20090618.patch:

        • serialize proxySource as DatanodeInfo only.
        • change BalancerDatanode not to implement Writable since it is not used anywhere.

        The existing TestBlockReplacement is already serializing proxySource as DatanodeInfo. So, no new test is added.

        Show
        Tsz Wo Nicholas Sze added a comment - 6079_20090618.patch: serialize proxySource as DatanodeInfo only. change BalancerDatanode not to implement Writable since it is not used anywhere. The existing TestBlockReplacement is already serializing proxySource as DatanodeInfo. So, no new test is added.
        Hide
        Hairong Kuang added a comment -

        +1. I agree that serialization/deserilization should use the same type.

        Show
        Hairong Kuang added a comment - +1. I agree that serialization/deserilization should use the same type.
        Hide
        Tsz Wo Nicholas Sze added a comment -
             [exec] -1 overall.
             [exec]
             [exec] +1 @author. The patch does not contain any @author tags.
             [exec]
             [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
             [exec] Please justify why no tests are needed for this patch.
             [exec]
             [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
             [exec]
             [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
             [exec]
             [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec]
             [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        

        Ran related unit tests locally. Everything works fine.

        Show
        Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Ran related unit tests locally. Everything works fine.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #872 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/872/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development