Hadoop Common
  1. Hadoop Common
  2. HADOOP-6031

Remove @author tags from Java source files

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Excluding first 2 results there are total 28 @author tags in java source files .

      hostname:Hadoop rphulari$ grep -r "@author"  .
      ./.svn/text-base/CHANGES.txt.svn-base: 69. HADOOP-1147.  Remove @author tags from Java source files.
      ./CHANGES.txt: 69. HADOOP-1147.  Remove @author tags from Java source files.
      ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/IFSImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSInputStream.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSOutputStream.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KosmosFileSystem.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/IFSImpl.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/KFSImpl.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/KFSOutputStream.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/core/org/apache/hadoop/fs/kfs/KosmosFileSystem.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/test/bin/.svn/text-base/test-patch.sh.svn-base:### Check for @author tags in the patch
      ./src/test/bin/.svn/text-base/test-patch.sh.svn-base:  echo "    Checking there are no @author tags in the patch."
      ./src/test/bin/.svn/text-base/test-patch.sh.svn-base:  authorTags=`$GREP -c -i '@author' $PATCH_DIR/patch`
      ./src/test/bin/.svn/text-base/test-patch.sh.svn-base:  echo "There appear to be $authorTags @author tags in the patch."
      ./src/test/bin/.svn/text-base/test-patch.sh.svn-base:    -1 @author.  The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
      ./src/test/bin/.svn/text-base/test-patch.sh.svn-base:    +1 @author.  The patch does not contain any @author tags."
      ./src/test/bin/test-patch.sh:### Check for @author tags in the patch
      ./src/test/bin/test-patch.sh:  echo "    Checking there are no @author tags in the patch."
      ./src/test/bin/test-patch.sh:  authorTags=`$GREP -c -i '@author' $PATCH_DIR/patch`
      ./src/test/bin/test-patch.sh:  echo "There appear to be $authorTags @author tags in the patch."
      ./src/test/bin/test-patch.sh:    -1 @author.  The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
      ./src/test/bin/test-patch.sh:    +1 @author.  The patch does not contain any @author tags."
      ./src/test/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSEmulationImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/test/core/org/apache/hadoop/fs/kfs/.svn/text-base/TestKosmosFileSystem.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
      ./src/test/core/org/apache/hadoop/fs/kfs/KFSEmulationImpl.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/test/core/org/apache/hadoop/fs/kfs/TestKosmosFileSystem.java: * @author: Sriram Rao (Kosmix Corp.)
      ./src/test/hdfs/org/apache/hadoop/hdfs/.svn/text-base/TestModTime.java.svn-base: * @author Dhruba Borthakur
      ./src/test/hdfs/org/apache/hadoop/hdfs/TestModTime.java: * @author Dhruba Borthakur
      hostname:Hadoop rphulari$ grep -r "@author"  . | wc -l
            30    
      
      

        Activity

        Hide
        Ravi Phulari added a comment -

        Correction to earlier description . Actual changes required java source files are -

        ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/IFSImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSInputStream.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSOutputStream.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KosmosFileSystem.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/IFSImpl.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/KFSImpl.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/KFSOutputStream.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/core/org/apache/hadoop/fs/kfs/KosmosFileSystem.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/test/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSEmulationImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/test/core/org/apache/hadoop/fs/kfs/.svn/text-base/TestKosmosFileSystem.java.svn-base: * @author: Sriram Rao (Kosmix Corp.)
        ./src/test/core/org/apache/hadoop/fs/kfs/KFSEmulationImpl.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/test/core/org/apache/hadoop/fs/kfs/TestKosmosFileSystem.java: * @author: Sriram Rao (Kosmix Corp.)
        ./src/test/hdfs/org/apache/hadoop/hdfs/.svn/text-base/TestModTime.java.svn-base: * @author Dhruba Borthakur
        ./src/test/hdfs/org/apache/hadoop/hdfs/TestModTime.java: * @author Dhruba Borthakur
        
        
        Show
        Ravi Phulari added a comment - Correction to earlier description . Actual changes required java source files are - ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/IFSImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSInputStream.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSOutputStream.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/.svn/text-base/KosmosFileSystem.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/IFSImpl.java: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/KFSImpl.java: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/KFSInputStream.java: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/KFSOutputStream.java: * @author: Sriram Rao (Kosmix Corp.) ./src/core/org/apache/hadoop/fs/kfs/KosmosFileSystem.java: * @author: Sriram Rao (Kosmix Corp.) ./src/test/core/org/apache/hadoop/fs/kfs/.svn/text-base/KFSEmulationImpl.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/test/core/org/apache/hadoop/fs/kfs/.svn/text-base/TestKosmosFileSystem.java.svn-base: * @author: Sriram Rao (Kosmix Corp.) ./src/test/core/org/apache/hadoop/fs/kfs/KFSEmulationImpl.java: * @author: Sriram Rao (Kosmix Corp.) ./src/test/core/org/apache/hadoop/fs/kfs/TestKosmosFileSystem.java: * @author: Sriram Rao (Kosmix Corp.) ./src/test/hdfs/org/apache/hadoop/hdfs/.svn/text-base/TestModTime.java.svn-base: * @author Dhruba Borthakur ./src/test/hdfs/org/apache/hadoop/hdfs/TestModTime.java: * @author Dhruba Borthakur
        Hide
        Ravi Phulari added a comment -

        Attaching patch .

        Show
        Ravi Phulari added a comment - Attaching patch .
        Hide
        Ravi Phulari added a comment -

        Submitting patch .
        Manually verified that no @author tags are included in java source files.

        hostname:Hadoop rphulari$ grep -Ir --exclude="*\.svn*" "@author" .
        ./CHANGES.txt: 69. HADOOP-1147.  Remove @author tags from Java source files.
        ./src/test/bin/test-patch.sh:### Check for @author tags in the patch
        ./src/test/bin/test-patch.sh:  echo "    Checking there are no @author tags in the patch."
        ./src/test/bin/test-patch.sh:  authorTags=`$GREP -c -i '@author' $PATCH_DIR/patch`
        ./src/test/bin/test-patch.sh:  echo "There appear to be $authorTags @author tags in the patch."
        ./src/test/bin/test-patch.sh:    -1 @author.  The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions."
        ./src/test/bin/test-patch.sh:    +1 @author.  The patch does not contain any @author tags."
        hostname:Hadoop rphulari$ grep -Ir --exclude="*\.svn*" --include="*.java" "@author" .
        hostname:Hadoop rphulari$ 
        
        

        ant test-patch results

        [exec]
             [exec]
             [exec] -1 overall.
             [exec]
             [exec]     -1 @author.  The patch appears to contain 8 @author tags which the Hadoop community has agreed to not allow in code contributions.
             [exec]
             [exec]     +1 tests included.  The patch appears to include 9 new or modified tests.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release auditwarnings.
             [exec]
             [exec]
             [exec]
        
        
        Show
        Ravi Phulari added a comment - Submitting patch . Manually verified that no @author tags are included in java source files. hostname:Hadoop rphulari$ grep -Ir --exclude= "*\.svn*" "@author" . ./CHANGES.txt: 69. HADOOP-1147. Remove @author tags from Java source files. ./src/test/bin/test-patch.sh:### Check for @author tags in the patch ./src/test/bin/test-patch.sh: echo " Checking there are no @author tags in the patch." ./src/test/bin/test-patch.sh: authorTags=`$GREP -c -i '@author' $PATCH_DIR/patch` ./src/test/bin/test-patch.sh: echo "There appear to be $authorTags @author tags in the patch." ./src/test/bin/test-patch.sh: -1 @author. The patch appears to contain $authorTags @author tags which the Hadoop community has agreed to not allow in code contributions." ./src/test/bin/test-patch.sh: +1 @author. The patch does not contain any @author tags." hostname:Hadoop rphulari$ grep -Ir --exclude= "*\.svn*" --include= "*.java" "@author" . hostname:Hadoop rphulari$ ant test-patch results [exec] [exec] [exec] -1 overall. [exec] [exec] -1 @author. The patch appears to contain 8 @author tags which the Hadoop community has agreed to not allow in code contributions. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release auditwarnings. [exec] [exec] [exec]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 good catches

        Show
        Tsz Wo Nicholas Sze added a comment - +1 good catches
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Ravi!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Ravi!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #867 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/867/ )

          People

          • Assignee:
            Ravi Phulari
            Reporter:
            Ravi Phulari
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development