Hadoop Common
  1. Hadoop Common
  2. HADOOP-6009

S3N listStatus incorrectly returns null instead of empty array when called on empty root

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.18.3
    • Fix Version/s: 0.21.0
    • Component/s: fs/s3
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Null means the directory does not exist, which is obviously not the case.

      1. HADOOP-6009.patch
        1 kB
        Tom White
      2. HADOOP-6009-0.patch
        1 kB
        Ian Nowland

        Issue Links

          Activity

          Hide
          Ian Nowland added a comment -

          Fix with unit test.

          Show
          Ian Nowland added a comment - Fix with unit test.
          Hide
          Tom White added a comment -

          +1 looks good to me.

          Show
          Tom White added a comment - +1 looks good to me.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12410346/HADOOP-6009-0.patch
          against trunk revision 807149.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/626/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410346/HADOOP-6009-0.patch against trunk revision 807149. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/626/console This message is automatically generated.
          Hide
          Tom White added a comment -

          Re-generated patch for trunk.

          Show
          Tom White added a comment - Re-generated patch for trunk.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12418796/HADOOP-6009.patch
          against trunk revision 812031.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418796/HADOOP-6009.patch against trunk revision 812031. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/21/console This message is automatically generated.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Ian!

          Show
          Tom White added a comment - I've just committed this. Thanks Ian!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/20/)
          . S3N listStatus incorrectly returns null instead of empty array when called on empty root. Contributed by Ian Nowland.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/20/ ) . S3N listStatus incorrectly returns null instead of empty array when called on empty root. Contributed by Ian Nowland.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #90 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/90/)
          . S3N listStatus incorrectly returns null instead of empty array when called on empty root. Contributed by Ian Nowland.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #90 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/90/ ) . S3N listStatus incorrectly returns null instead of empty array when called on empty root. Contributed by Ian Nowland.

            People

            • Assignee:
              Ian Nowland
              Reporter:
              Ian Nowland
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development