Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are javac warnings in the following tests:

      src/test/hdfs/org/apache/hadoop/hdfs/TestFileCreation.java
      src/test/hdfs/org/apache/hadoop/hdfs/TestSmallBlock.java
      src/test/hdfs/org/apache/hadoop/hdfs/TestFileStatus.java
      src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShellGenericOptions.java
      src/test/hdfs/org/apache/hadoop/hdfs/TestSeekBug.java
      src/test/hdfs/org/apache/hadoop/hdfs/TestDFSStartupVersions.java
      
      1. 5954_20090601.patch
        6 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -
             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 20 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        Run all tests mentioned in the description locally. Passed all of them.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 20 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Run all tests mentioned in the description locally. Passed all of them.
        Hide
        jghoman Jakob Homan added a comment -

        +1. Looks good.

        Show
        jghoman Jakob Homan added a comment - +1. Looks good.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        5954_20090601.patch: this is the correct file.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - 5954_20090601.patch: this is the correct file.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        5953_20090601.patch: fix javac warnings

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - 5953_20090601.patch: fix javac warnings

          People

          • Assignee:
            szetszwo Tsz Wo Nicholas Sze
            Reporter:
            szetszwo Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development