Hadoop Common
  1. Hadoop Common
  2. HADOOP-5899

Minor - move info log to the right place to avoid printing unnecessary log

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Log below should only be printed in FSEditLog.processIOErros() encounters error condition. Currently this log is printed unnecessarily even when there is no error.
      INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....

      1. log.patch
        0.9 kB
        Suresh Srinivas

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Suresh!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Suresh!
        Hide
        Suresh Srinivas added a comment -

        Test is not included because this just move code that generates info logs. The failed tests given below are not related to this patch:
        org.apache.hadoop.mapred.lib.TestCombineFileInputFormat.<init>
        org.apache.hadoop.mapred.TestQueueCapacities.testMultipleQueues

        Show
        Suresh Srinivas added a comment - Test is not included because this just move code that generates info logs. The failed tests given below are not related to this patch: org.apache.hadoop.mapred.lib.TestCombineFileInputFormat.<init> org.apache.hadoop.mapred.TestQueueCapacities.testMultipleQueues
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12408831/log.patch
        against trunk revision 780114.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408831/log.patch against trunk revision 780114. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/console This message is automatically generated.
        Hide
        Boris Shkolnik added a comment -

        +1
        Looks good

        Show
        Boris Shkolnik added a comment - +1 Looks good
        Hide
        Suresh Srinivas added a comment -

        Log is moved so that it is printed only during error conditions

        Show
        Suresh Srinivas added a comment - Log is moved so that it is printed only during error conditions

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development