Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-5823 added DeprecatedUTF8 class as a wrapper for UTF8. Though UTF8 is deprecated, it is used in many places and most likely will continue to be used for quite sometime. My initial thought was that other packages might want to use the wrapper DeprecatedUTF8.

      But the current suggestion (discussed in HADOOP-5823) is to move the class to o.a.h.hdfs.

      Alternately we could have just use "@SuppressWarnings" rather than introducing a new class.

      1. HADOOP-5866.patch
        5 kB
        Raghu Angadi
      2. HADOOP-5866.patch
        8 kB
        Raghu Angadi
      3. HADOOP-5866.patch
        8 kB
        Raghu Angadi

        Issue Links

          Activity

          Raghu Angadi created issue -
          Raghu Angadi made changes -
          Field Original Value New Value
          Link This issue is related to HADOOP-5823 [ HADOOP-5823 ]
          Raghu Angadi made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Description
          HADOOP-5823 added {{DeprecatedUTF8}} class as a wrapper for UTF8. Though UTF8 is deprecated, it is used in many places and most likely will continue to be used for quite sometime. My initial thought was that other packages might want to use the wrapper {{DeprecatedUTF8}}.

          But the current suggestion (discussed in HADOOP-5823) is to move the class to o.a.h.hdfs.

          Alternately we could have just use "@SuppressWarnings" rather than introducing a new class.
          HADOOP-5823 added {{DeprecatedUTF8}} class as a wrapper for UTF8. Though UTF8 is deprecated, it is used in many places and most likely will continue to be used for quite sometime. My initial thought was that other packages might want to use the wrapper {{DeprecatedUTF8}}.

          But the current suggestion (discussed in HADOOP-5823) is to move the class to o.a.h.hdfs.

          Alternately we could have just use "@SuppressWarnings" rather than introducing a new class.
          Hide
          Raghu Angadi added a comment -

          The attached patch just moves DeprecatedUTF8 from o.a.h.io to o.a.h.hdfs. It is declared public since it is used in multiple packages under hdfs.

          Show
          Raghu Angadi added a comment - The attached patch just moves DeprecatedUTF8 from o.a.h.io to o.a.h.hdfs. It is declared public since it is used in multiple packages under hdfs.
          Raghu Angadi made changes -
          Attachment HADOOP-5866.patch [ 12408427 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Forgot to add the new file?

          Show
          Tsz Wo Nicholas Sze added a comment - Forgot to add the new file?
          Hide
          Raghu Angadi added a comment -

          Thanks Nicholas. corrected patch is attached.

          Show
          Raghu Angadi added a comment - Thanks Nicholas. corrected patch is attached.
          Raghu Angadi made changes -
          Attachment HADOOP-5866.patch [ 12408428 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1

          Show
          Tsz Wo Nicholas Sze added a comment - +1
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Reviewed]
          Component/s dfs [ 12310710 ]
          Raghu Angadi made changes -
          Assignee Raghu Angadi [ rangadi ]
          Hide
          Raghu Angadi added a comment -

          Thanks Nicholas for the review.

          Updated patch is attached. The previous one was incomplete. NamespaceInfo.java was not updated.

          ant test-patch:

               [exec] -1 overall.
               [exec]
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec]
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec]
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec]
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec]
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
               [exec]
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
               [exec]
            
          Show
          Raghu Angadi added a comment - Thanks Nicholas for the review. Updated patch is attached. The previous one was incomplete. NamespaceInfo.java was not updated. ant test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
          Raghu Angadi made changes -
          Attachment HADOOP-5866.patch [ 12408507 ]
          Hide
          Raghu Angadi added a comment -

          I just committed this.

          Show
          Raghu Angadi added a comment - I just committed this.
          Raghu Angadi made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Owen O'Malley made changes -
          Component/s dfs [ 12310710 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Raghu Angadi
              Reporter:
              Raghu Angadi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development