Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 0.21.0
-
Component/s: None
-
Labels:None
-
Hadoop Flags:Reviewed
Description
Fix javac warnings in the following files:
fs/FileSystem.java
fs/ChecksumException.java
fs/FSError.java
fs/kfs/KFSInputStream.java
fs/s3/S3FileSystemException.java
fs/s3/S3Exception.java
fs/s3/VersionMismatchException.java
util/ProcfsBasedProcessTree.java
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
+1 patch looks good
Show
Tsz Wo Nicholas Sze
added a comment - +1 patch looks good
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Since the patch fixes syntax related warnings and does not change any logic, I will commit this without submitting to Hudson for saving some cycles.
Show
Tsz Wo Nicholas Sze
added a comment -
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Since the patch fixes syntax related warnings and does not change any logic, I will commit this without submitting to Hudson for saving some cycles.
I have committed this. Thanks, Hairong!
Show
Tsz Wo Nicholas Sze
added a comment - I have committed this. Thanks, Hairong!
A patch for review. No unit tests are included because all changes are trivial.