Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Fixing javac warnings found in some of the java files

      1. fix_warnings.patch
        11 kB
        Suresh Srinivas
      2. fix_warnings.patch
        15 kB
        Suresh Srinivas
      3. fix_warnings.patch
        15 kB
        Suresh Srinivas

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        How about replace switch-case statement by if-then statements, instead of adding @SuppressWarnings("fallthrough")?

        Show
        Tsz Wo Nicholas Sze added a comment - How about replace switch-case statement by if-then statements, instead of adding @SuppressWarnings("fallthrough")?
        Hide
        Suresh Srinivas added a comment -

        Here is the new patch that incorporates the change you suggested.

        Show
        Suresh Srinivas added a comment - Here is the new patch that incorporates the change you suggested.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Suresh Srinivas added a comment -

        Old patch was failing to apply to the latest trunk. Here is the updated patch with test-patch results. No tests included as this patch fixes only javac warnings:
        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no tests are needed for this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Suresh Srinivas added a comment - Old patch was failing to apply to the latest trunk. Here is the updated patch with test-patch results. No tests included as this patch fixes only javac warnings: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Suresh Srinivas added a comment -

        Passed unit tests as well

        Show
        Suresh Srinivas added a comment - Passed unit tests as well
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Suresh!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Suresh!

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development