Hadoop Common
  1. Hadoop Common
  2. HADOOP-5809

Job submission fails if hadoop.tmp.dir exists

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently in trunk, the job submission fails, stating "Mkdirs failed to create $

      {hadoop.tmp.dir}

      "

      1. hadoop-5809-v2.patch
        4 kB
        Jothi Padmanabhan
      2. HADOOP-5809-1.patch
        5 kB
        Sreekanth Ramakrishnan
      3. HADOOP-5809.patch
        0.8 kB
        Sreekanth Ramakrishnan

        Activity

        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching patch which fixes this issue. Submitted a sleep job to verify if the patch fixes the issue.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching patch which fixes this issue. Submitted a sleep job to verify if the patch fixes the issue.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12407853/HADOOP-5809.patch
        against trunk revision 774018.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no tests are needed for this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407853/HADOOP-5809.patch against trunk revision 774018. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/331/console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1. Patch looks good to me, and I just ran into the same issue.

        Show
        Todd Lipcon added a comment - +1. Patch looks good to me, and I just ran into the same issue.
        Hide
        Amar Kamat added a comment -

        Can someone plz take this forward and commit it.

        Show
        Amar Kamat added a comment - Can someone plz take this forward and commit it.
        Hide
        Sreekanth Ramakrishnan added a comment -

        The issue cannot be unit tested as it is invoked when job client is called thro' mapred command. I have manually tested and verified the fix works.

        Show
        Sreekanth Ramakrishnan added a comment - The issue cannot be unit tested as it is invoked when job client is called thro' mapred command. I have manually tested and verified the fix works.
        Hide
        Devaraj Das added a comment -

        Could you add a testcase that would test this please. Thanks!

        Show
        Devaraj Das added a comment - Could you add a testcase that would test this please. Thanks!
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching the patch which incorporates the fix and has added a new test case.

        Test case does following:

        • Writes out a Java program which would create a file in test.data.dir.
        • Use Compiler api to compile the java file.
        • Create a runnable jar file from compiled class file.
        • Use RunJar to execute the jar. If RunJar throws exception or VM exits, the test case reports a Failure/Error.
        Show
        Sreekanth Ramakrishnan added a comment - Attaching the patch which incorporates the fix and has added a new test case. Test case does following: Writes out a Java program which would create a file in test.data.dir . Use Compiler api to compile the java file. Create a runnable jar file from compiled class file. Use RunJar to execute the jar. If RunJar throws exception or VM exits, the test case reports a Failure/Error.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12408265/HADOOP-5809-1.patch
        against trunk revision 776438.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408265/HADOOP-5809-1.patch against trunk revision 776438. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/360/console This message is automatically generated.
        Hide
        Philip Zeyliger added a comment -

        +1 on the patch. This just bit me too.

        Show
        Philip Zeyliger added a comment - +1 on the patch. This just bit me too.
        Hide
        Jothi Padmanabhan added a comment -

        Simplifying the test case quite a bit

        Show
        Jothi Padmanabhan added a comment - Simplifying the test case quite a bit
        Hide
        Chris Douglas added a comment -

        I committed this. Thanks Sreekanth and Jothi.

        Show
        Chris Douglas added a comment - I committed this. Thanks Sreekanth and Jothi.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #863 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/863/ )

          People

          • Assignee:
            Sreekanth Ramakrishnan
            Reporter:
            Sreekanth Ramakrishnan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development